summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSiva Chandra <sivachandra@google.com>2015-03-16 22:45:05 +0000
committerSiva Chandra <sivachandra@google.com>2015-03-16 22:45:05 +0000
commit588ec02f19ab726141b8202a443a75e668a802da (patch)
treead03e5f572231a287605c65eed09646314985e75
parentc5bc68e7ab51d34e2edfad8c883b55e433bed9bd (diff)
downloadbcm5719-llvm-588ec02f19ab726141b8202a443a75e668a802da.tar.gz
bcm5719-llvm-588ec02f19ab726141b8202a443a75e668a802da.zip
Enable TestDataFormatterStdMap on linux (libstdc++) with clang.
Summary: This test should have been enabled along with 7181dae1248cc1b03505cca1b7c6e3dfeffefc0a, but since the test was actually crashing, I thought it was a much deeper problem. Turns out, all I had to do was to add "-fno-limit-debug-info" when compiling the test case. The test is still skipped when the testcase is compiled with GCC. Test Plan: dotest.py -p TestDataFormatterStdMap Reviewers: vharron Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D8364 llvm-svn: 232432
-rw-r--r--lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile7
-rw-r--r--lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py4
2 files changed, 7 insertions, 4 deletions
diff --git a/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile b/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
index 17868d8a95f..2c6c3cf7284 100644
--- a/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
+++ b/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
@@ -4,4 +4,11 @@ CXX_SOURCES := main.cpp
USE_LIBSTDCPP := 1
+# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
+# targets. Other targets do not, which causes this test to fail.
+# This flag enables FullDebugInfo for all targets.
+ifneq (,$(findstring clang,$(CC)))
+ CFLAGS_EXTRAS += -fno-limit-debug-info
+endif
+
include $(LEVEL)/Makefile.rules
diff --git a/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py b/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
index 42c2120d8b4..a349168d849 100644
--- a/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
+++ b/lldb/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
@@ -24,10 +24,6 @@ class StdMapDataFormatterTestCase(TestBase):
@expectedFailureIcc # llvm.org/pr15301: LLDB prints incorrect size of
# libstdc++ containers
@skipIfFreeBSD
- @skipIfLinux # non-core functionality, need to reenable and fix
- # later (DES 2014.11.07). Most likely failing because
- # of mis-match is version of libstdc++ supported by
- # the data-formatters.
@dwarf_test
def test_with_dwarf_and_run_command(self):
"""Test data formatter commands."""
OpenPOWER on IntegriCloud