diff options
| author | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2017-03-07 20:53:09 +0000 |
|---|---|---|
| committer | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2017-03-07 20:53:09 +0000 |
| commit | 55d10423a6a1f8286be05651b9c7143ef4e58b22 (patch) | |
| tree | 8c70e722e9867bedf2b18445d688095cce13784a | |
| parent | 5c7924fca51e0580bba5d9103b43558889a149bb (diff) | |
| download | bcm5719-llvm-55d10423a6a1f8286be05651b9c7143ef4e58b22.tar.gz bcm5719-llvm-55d10423a6a1f8286be05651b9c7143ef4e58b22.zip | |
[GlobalISel] Don't translate intrinsics with metadata parameters.
Some intrinsics take metadata parameters. These all need custom
handling of some form, and cannot possibly be lowered generically to
G_INTRINSIC calls with vreg operands.
Reject them, instead of hitting an assert later in getOrCreateVReg.
llvm-svn: 297209
| -rw-r--r-- | llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp | 3 | ||||
| -rw-r--r-- | llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll | 11 |
2 files changed, 14 insertions, 0 deletions
diff --git a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp index 1a70947a4aa..869589b9aa7 100644 --- a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp +++ b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp @@ -745,6 +745,9 @@ bool IRTranslator::translateCall(const User &U, MachineIRBuilder &MIRBuilder) { MIRBuilder.buildIntrinsic(ID, Res, !CI.doesNotAccessMemory()); for (auto &Arg : CI.arg_operands()) { + // Some intrinsics take metadata parameters. Reject them. + if (isa<MetadataAsValue>(Arg)) + return false; if (ConstantInt *CI = dyn_cast<ConstantInt>(Arg)) MIB.addImm(CI->getSExtValue()); else diff --git a/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll b/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll index 02f6e3bd402..4510f5cf054 100644 --- a/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll +++ b/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll @@ -107,3 +107,14 @@ define i64 @atomic_ops(i64* %addr) { %res = load atomic i64, i64* %addr seq_cst, align 8 ret i64 %res } + +; Make sure we don't mess up metadata arguments. +declare void @llvm.write_register.i64(metadata, i64) + +; FALLBACK-WITH-REPORT-ERR: remark: <unknown>:0:0: unable to translate instruction: call: ' call void @llvm.write_register.i64(metadata !0, i64 0)' (in function: test_write_register_intrin) +; FALLBACK-WITH-REPORT-ERR: warning: Instruction selection used fallback path for test_write_register_intrin +; FALLBACK-WITH-REPORT-LABEL: test_write_register_intrin: +define void @test_write_register_intrin() { + call void @llvm.write_register.i64(metadata !{!"sp"}, i64 0) + ret void +} |

