summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAditya Nandakumar <aditya_nandakumar@apple.com>2019-08-12 21:28:12 +0000
committerAditya Nandakumar <aditya_nandakumar@apple.com>2019-08-12 21:28:12 +0000
commit55371e697cd41cc1c282aa9a7bc3baa6164659a9 (patch)
tree00fb984385c24003040bbb33ca9257e6534d40a2
parent74cec618f304e88ca83875e84978acfa1b8cc1ec (diff)
downloadbcm5719-llvm-55371e697cd41cc1c282aa9a7bc3baa6164659a9.tar.gz
bcm5719-llvm-55371e697cd41cc1c282aa9a7bc3baa6164659a9.zip
[GISel]: Fix a bug in KnownBits where we should have been using SizeInBits
https://reviews.llvm.org/D66039 We were using getIndexSize instead of getIndexSizeInBits(). Added test case for G_PTRTOINT and G_INTTOPTR. llvm-svn: 368618
-rw-r--r--llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp2
-rw-r--r--llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp16
2 files changed, 17 insertions, 1 deletions
diff --git a/llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp b/llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp
index 12e69f8a788..aef43568b63 100644
--- a/llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp
@@ -297,7 +297,7 @@ void GISelKnownBits::computeKnownBitsImpl(Register R, KnownBits &Known,
Register SrcReg = MI.getOperand(1).getReg();
LLT SrcTy = MRI.getType(SrcReg);
unsigned SrcBitWidth = SrcTy.isPointer()
- ? DL.getIndexSize(SrcTy.getAddressSpace())
+ ? DL.getIndexSizeInBits(SrcTy.getAddressSpace())
: SrcTy.getSizeInBits();
assert(SrcBitWidth && "SrcBitWidth can't be zero");
Known = Known.zextOrTrunc(SrcBitWidth, true);
diff --git a/llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp b/llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
index 0cd35958f9f..2fd09feb1f7 100644
--- a/llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
+++ b/llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
@@ -24,6 +24,22 @@ TEST_F(GISelMITest, TestKnownBitsCst) {
EXPECT_EQ((uint64_t)1, Res.One.getZExtValue());
EXPECT_EQ((uint64_t)0xfe, Res.Zero.getZExtValue());
}
+TEST_F(GISelMITest, TestKnownBitsPtrToIntViceVersa) {
+ StringRef MIRString = " %3:_(s16) = G_CONSTANT i16 256\n"
+ " %4:_(p0) = G_INTTOPTR %3\n"
+ " %5:_(s32) = G_PTRTOINT %4\n"
+ " %6:_(s32) = COPY %5\n";
+ setUp(MIRString);
+ if (!TM)
+ return;
+ unsigned CopyReg = Copies[Copies.size() - 1];
+ MachineInstr *FinalCopy = MRI->getVRegDef(CopyReg);
+ unsigned SrcReg = FinalCopy->getOperand(1).getReg();
+ GISelKnownBits Info(*MF);
+ KnownBits Res = Info.getKnownBits(SrcReg);
+ EXPECT_EQ(256u, Res.One.getZExtValue());
+ EXPECT_EQ(0xfffffeffu, Res.Zero.getZExtValue());
+}
TEST_F(GISelMITest, TestKnownBits) {
OpenPOWER on IntegriCloud