diff options
| author | David Blaikie <dblaikie@gmail.com> | 2012-02-10 05:15:16 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2012-02-10 05:15:16 +0000 |
| commit | 54f5d859ad811e7c765865a358bad1ac401cb08a (patch) | |
| tree | de79bd46b5ca361653ccda04a2dca84902c649c5 | |
| parent | 5b6562f58cb44d9f0989879b218c3c7b28366062 (diff) | |
| download | bcm5719-llvm-54f5d859ad811e7c765865a358bad1ac401cb08a.tar.gz bcm5719-llvm-54f5d859ad811e7c765865a358bad1ac401cb08a.zip | |
Move -Wswitch from -Wmost to -Wall, consitent with GCC.
This is a relatively noisy warning for a codebase not explicitly designed for
it (effectively enforcing a stylistic constraint about the use of defaults
in switches over enums) & there's nothing Clang does to clean up the noise
when compared to GCC's implementation so the same decision seems suitable.
llvm-svn: 150230
| -rw-r--r-- | clang/include/clang/Basic/DiagnosticGroups.td | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/clang/include/clang/Basic/DiagnosticGroups.td b/clang/include/clang/Basic/DiagnosticGroups.td index 1a733d28e0f..4fa19826b9b 100644 --- a/clang/include/clang/Basic/DiagnosticGroups.td +++ b/clang/include/clang/Basic/DiagnosticGroups.td @@ -317,7 +317,6 @@ def Most : DiagGroup<"most", [ Reorder, ReturnType, SelfAssignment, - Switch, SizeofArrayArgument, Trigraphs, Uninitialized, @@ -331,8 +330,8 @@ def Most : DiagGroup<"most", [ // Thread Safety warnings def ThreadSafety : DiagGroup<"thread-safety">; -// -Wall is -Wmost -Wparentheses -Wdangling-else -def : DiagGroup<"all", [DanglingElse, Most, Parentheses]>; +// -Wall is -Wmost -Wparentheses -Wdangling-else -Wswitch +def : DiagGroup<"all", [DanglingElse, Most, Parentheses, Switch]>; // Aliases. def : DiagGroup<"", [Extra]>; // -W = -Wextra |
