diff options
author | Pavel Labath <labath@google.com> | 2017-02-17 13:39:50 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2017-02-17 13:39:50 +0000 |
commit | 4f19fce2d6cdceb1f228446c041aa897df075f24 (patch) | |
tree | 1b1d3eaf2a9c87b0fa49a6796c3311f71ce22f4c | |
parent | 24610211505bd785fc3ea94ddb93732aa3a063ce (diff) | |
download | bcm5719-llvm-4f19fce2d6cdceb1f228446c041aa897df075f24.tar.gz bcm5719-llvm-4f19fce2d6cdceb1f228446c041aa897df075f24.zip |
Fix compiler warnings for missing switch cases in lldb.
Summary:
There have been a few new values added to a few LLVM enums
this change makes sure that LLDB code handles them correctly.
Reviewers: labath
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D30005
Author: Eugene Zemtsov <ezemtsov@google.com>
llvm-svn: 295445
4 files changed, 10 insertions, 87 deletions
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp index 0f08dd330e9..bb502fa1df9 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp @@ -139,6 +139,7 @@ bool ClangASTSource::FindExternalVisibleDeclsByName( case DeclarationName::CXXConstructorName: case DeclarationName::CXXDestructorName: case DeclarationName::CXXConversionFunctionName: + case DeclarationName::CXXDeductionGuideName: SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); return false; } diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp index a97b5da1573..de11a3625ca 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp @@ -1907,6 +1907,7 @@ bool GDBRemoteCommunicationClient::GetCurrentProcessInfo(bool allow_lazy) { llvm::Triple triple(llvm::Twine("-") + vendor_name + "-" + os_name); assert(triple.getObjectFormat() != llvm::Triple::UnknownObjectFormat); + assert(triple.getObjectFormat() != llvm::Triple::Wasm); switch (triple.getObjectFormat()) { case llvm::Triple::MachO: m_process_arch.SetArchitecture(eArchTypeMachO, cpu, sub); @@ -1917,6 +1918,10 @@ bool GDBRemoteCommunicationClient::GetCurrentProcessInfo(bool allow_lazy) { case llvm::Triple::COFF: m_process_arch.SetArchitecture(eArchTypeCOFF, cpu, sub); break; + case llvm::Triple::Wasm: + if (log) + log->Printf("error: not supported target architecture"); + return false; case llvm::Triple::UnknownObjectFormat: if (log) log->Printf("error: failed to determine target architecture"); diff --git a/lldb/source/Symbol/ClangASTContext.cpp b/lldb/source/Symbol/ClangASTContext.cpp index eed342d008c..8d5186185cd 100644 --- a/lldb/source/Symbol/ClangASTContext.cpp +++ b/lldb/source/Symbol/ClangASTContext.cpp @@ -4316,6 +4316,8 @@ ClangASTContext::GetTypeClass(lldb::opaque_compiler_type_t type) { break; case clang::Type::TemplateSpecialization: break; + case clang::Type::DeducedTemplateSpecialization: + break; case clang::Type::Atomic: break; case clang::Type::Pipe: @@ -5124,6 +5126,7 @@ lldb::Encoding ClangASTContext::GetEncoding(lldb::opaque_compiler_type_t type, case clang::Type::TypeOf: case clang::Type::Decltype: case clang::Type::TemplateSpecialization: + case clang::Type::DeducedTemplateSpecialization: case clang::Type::Atomic: case clang::Type::Adjusted: case clang::Type::Pipe: @@ -5273,6 +5276,7 @@ lldb::Format ClangASTContext::GetFormat(lldb::opaque_compiler_type_t type) { case clang::Type::TypeOf: case clang::Type::Decltype: case clang::Type::TemplateSpecialization: + case clang::Type::DeducedTemplateSpecialization: case clang::Type::Atomic: case clang::Type::Adjusted: case clang::Type::Pipe: diff --git a/lldb/source/Symbol/ClangExternalASTSourceCallbacks.cpp b/lldb/source/Symbol/ClangExternalASTSourceCallbacks.cpp index e39baea8ead..77d455b8007 100644 --- a/lldb/source/Symbol/ClangExternalASTSourceCallbacks.cpp +++ b/lldb/source/Symbol/ClangExternalASTSourceCallbacks.cpp @@ -61,93 +61,6 @@ bool ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName( } std::string decl_name(clang_decl_name.getAsString()); - - switch (clang_decl_name.getNameKind()) { - // Normal identifiers. - case clang::DeclarationName::Identifier: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"Identifier\", name = \"%s\")\n", decl_ctx, - // decl_name.c_str()); - if (clang_decl_name.getAsIdentifierInfo()->getBuiltinID() != 0) { - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - } - break; - - case clang::DeclarationName::ObjCZeroArgSelector: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"ObjCZeroArgSelector\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::ObjCOneArgSelector: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"ObjCOneArgSelector\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::ObjCMultiArgSelector: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"ObjCMultiArgSelector\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::CXXConstructorName: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"CXXConstructorName\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::CXXDestructorName: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"CXXDestructorName\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::CXXConversionFunctionName: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"CXXConversionFunctionName\", name = - // \"%s\")\n", decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::CXXOperatorName: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"CXXOperatorName\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::CXXLiteralOperatorName: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"CXXLiteralOperatorName\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - - case clang::DeclarationName::CXXUsingDirective: - // printf - // ("ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName(decl_ctx - // = %p, decl_name = { kind = \"CXXUsingDirective\", name = \"%s\")\n", - // decl_ctx, decl_name.c_str()); - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); - return false; - } - SetNoExternalVisibleDeclsForName(decl_ctx, clang_decl_name); return false; } |