diff options
| author | Craig Topper <craig.topper@gmail.com> | 2017-04-23 17:16:26 +0000 |
|---|---|---|
| committer | Craig Topper <craig.topper@gmail.com> | 2017-04-23 17:16:26 +0000 |
| commit | 4e590e59a088128b7cc3733ed7ab4344cfcc4dc1 (patch) | |
| tree | b5827d4a992d36d3d61f11909c1ccf55ceab5ed6 | |
| parent | 652ca99622954c5373427bbd51257b7f23b61aed (diff) | |
| download | bcm5719-llvm-4e590e59a088128b7cc3733ed7ab4344cfcc4dc1.tar.gz bcm5719-llvm-4e590e59a088128b7cc3733ed7ab4344cfcc4dc1.zip | |
[APInt] Make clearUnusedBits branch free.
This makes the WordBits calculation calculate a value between 1 and 64 for the number of bits in the last word. Previously if the BitWidth was a multiple of 64 bits the WordBits value was 0 and we had to bail out early to avoid an undefined shift. Now with a value of 64 we no longer have an undefined shift issue.
This shows a 15-16k reduction in the size of the opt binary on my local x86-64 build.
llvm-svn: 301134
| -rw-r--r-- | llvm/include/llvm/ADT/APInt.h | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/llvm/include/llvm/ADT/APInt.h b/llvm/include/llvm/ADT/APInt.h index c697402341f..4b966faa6c1 100644 --- a/llvm/include/llvm/ADT/APInt.h +++ b/llvm/include/llvm/ADT/APInt.h @@ -138,15 +138,10 @@ private: /// zero'd out. APInt &clearUnusedBits() { // Compute how many bits are used in the final word - unsigned wordBits = BitWidth % APINT_BITS_PER_WORD; - if (wordBits == 0) - // If all bits are used, we want to leave the value alone. This also - // avoids the undefined behavior of >> when the shift is the same size as - // the word size (64). - return *this; + unsigned WordBits = ((BitWidth-1) % APINT_BITS_PER_WORD) + 1; // Mask out the high bits. - uint64_t mask = WORD_MAX >> (APINT_BITS_PER_WORD - wordBits); + uint64_t mask = WORD_MAX >> (APINT_BITS_PER_WORD - WordBits); if (isSingleWord()) VAL &= mask; else |

