diff options
| author | Howard Hinnant <hhinnant@apple.com> | 2013-10-05 00:07:35 +0000 |
|---|---|---|
| committer | Howard Hinnant <hhinnant@apple.com> | 2013-10-05 00:07:35 +0000 |
| commit | 4e07b5b95539634ef6ac6cf54be7355302101080 (patch) | |
| tree | 3a610abaff56ccab3e17f8ebcf6d80048f75170d | |
| parent | fa205cad7c32847ec124265fcc7d976ee8f6382e (diff) | |
| download | bcm5719-llvm-4e07b5b95539634ef6ac6cf54be7355302101080.tar.gz bcm5719-llvm-4e07b5b95539634ef6ac6cf54be7355302101080.zip | |
G M: Attached is a patch for libcxx's cmake file.
I've changed it so we don't set highest level warnings (all) for MSVC when building projects using cmake and instead leave the default. That's /W4 on my machine and seems to be ok.
With all warnings on for msvc, we see literally thousands of warnings. 99.99% aren't relevant and just obscure the ones that are.
I think the user can still override things if they want something different from the command line when using cmake.
llvm-svn: 192010
| -rw-r--r-- | libcxx/CMakeLists.txt | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/libcxx/CMakeLists.txt b/libcxx/CMakeLists.txt index 1d4375d30ae..15b76d224e6 100644 --- a/libcxx/CMakeLists.txt +++ b/libcxx/CMakeLists.txt @@ -185,7 +185,9 @@ macro(append_if list condition var) endmacro() # Get warning flags -append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WALL_FLAG -Wall) +if (NOT MSVC) + append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WALL_FLAG -Wall) +endif() append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_W_FLAG -W) append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WNO_UNUSED_PARAMETER_FLAG -Wno-unused-parameter) append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WWRITE_STRINGS_FLAG -Wwrite-strings) |
