diff options
| author | Renato Golin <renato.golin@linaro.org> | 2015-02-22 18:58:18 +0000 |
|---|---|---|
| committer | Renato Golin <renato.golin@linaro.org> | 2015-02-22 18:58:18 +0000 |
| commit | 4b1482e75c1787e509aac986e2c8f2355e98fb74 (patch) | |
| tree | c6a3e9204004f26ccda6d8f70ac60987bccd8467 | |
| parent | 3d4269ab05c74ca50f30e93ba8a416980544ab97 (diff) | |
| download | bcm5719-llvm-4b1482e75c1787e509aac986e2c8f2355e98fb74.tar.gz bcm5719-llvm-4b1482e75c1787e509aac986e2c8f2355e98fb74.zip | |
Revert "[ASan] Make the argument of '__sanitizer_annotate_contiguous_container' is not aligned error message easier to understand"
This reverts commit r230019, as it was breaking the ARM sanitizer buildbot
and let other errors be introduced since it wasn't fixed/reverted in
time.
llvm-svn: 230179
| -rw-r--r-- | compiler-rt/lib/asan/asan_report.cc | 2 | ||||
| -rw-r--r-- | compiler-rt/test/asan/TestCases/contiguous_container_crash.cc | 17 |
2 files changed, 3 insertions, 16 deletions
diff --git a/compiler-rt/lib/asan/asan_report.cc b/compiler-rt/lib/asan/asan_report.cc index 34593195b92..8706d5decc0 100644 --- a/compiler-rt/lib/asan/asan_report.cc +++ b/compiler-rt/lib/asan/asan_report.cc @@ -834,8 +834,6 @@ void ReportBadParamsToAnnotateContiguousContainer(uptr beg, uptr end, " old_mid : %p\n" " new_mid : %p\n", beg, end, old_mid, new_mid); - if (!IsAligned(beg, SHADOW_GRANULARITY)) - Report("ERROR: beg is not aligned by %d\n", SHADOW_GRANULARITY); stack->Print(); ReportErrorSummary("bad-__sanitizer_annotate_contiguous_container", stack); } diff --git a/compiler-rt/test/asan/TestCases/contiguous_container_crash.cc b/compiler-rt/test/asan/TestCases/contiguous_container_crash.cc index 9bea17765ea..143ae9d8ede 100644 --- a/compiler-rt/test/asan/TestCases/contiguous_container_crash.cc +++ b/compiler-rt/test/asan/TestCases/contiguous_container_crash.cc @@ -1,7 +1,6 @@ // RUN: %clangxx_asan -O %s -o %t // RUN: not %run %t crash 2>&1 | FileCheck --check-prefix=CHECK-CRASH %s -// RUN: not %run %t bad-bounds 2>&1 | FileCheck --check-prefix=CHECK-BAD-BOUNDS %s -// RUN: not %run %t bad-alignment 2>&1 | FileCheck --check-prefix=CHECK-BAD-ALIGNMENT %s +// RUN: not %run %t bad-bounds 2>&1 | FileCheck --check-prefix=CHECK-BAD %s // RUN: env ASAN_OPTIONS=detect_container_overflow=0 %run %t crash // // Test crash due to __sanitizer_annotate_contiguous_container. @@ -22,31 +21,21 @@ int TestCrash() { t[60] = 0; __sanitizer_annotate_contiguous_container(&t[0], &t[0] + 100, &t[0] + 100, &t[0] + 50); -// CHECK-CRASH: AddressSanitizer: container-overflow return (int)t[60 * one]; // Touches the poisoned memory. } void BadBounds() { long t[100]; -// CHECK-BAD-BOUNDS: ERROR: AddressSanitizer: bad parameters to __sanitizer_annotate_contiguous_container __sanitizer_annotate_contiguous_container(&t[0], &t[0] + 100, &t[0] + 101, &t[0] + 50); } -void BadAlignment() { - int t[100]; -// CHECK-BAD-ALIGNMENT: ERROR: AddressSanitizer: bad parameters to __sanitizer_annotate_contiguous_container -// CHECK-BAD-ALIGNMENT: ERROR: beg is not aligned by 8 - __sanitizer_annotate_contiguous_container(&t[1], &t[0] + 100, &t[1] + 10, - &t[0] + 50); -} - int main(int argc, char **argv) { assert(argc == 2); if (!strcmp(argv[1], "crash")) return TestCrash(); else if (!strcmp(argv[1], "bad-bounds")) BadBounds(); - else if (!strcmp(argv[1], "bad-alignment")) - BadAlignment(); } +// CHECK-CRASH: AddressSanitizer: container-overflow +// CHECK-BAD: ERROR: AddressSanitizer: bad parameters to __sanitizer_annotate_contiguous_container |

