summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorReid Kleckner <rnk@google.com>2018-12-18 01:36:06 +0000
committerReid Kleckner <rnk@google.com>2018-12-18 01:36:06 +0000
commit4ab50b858ed7c3dfee8cef040b5ed43c863e44d7 (patch)
tree5ef663abc3b37e02efd6d3429d61c5c136327b49
parentc646b4b05ef29e4705855a68948048e46dc6d914 (diff)
downloadbcm5719-llvm-4ab50b858ed7c3dfee8cef040b5ed43c863e44d7.tar.gz
bcm5719-llvm-4ab50b858ed7c3dfee8cef040b5ed43c863e44d7.zip
[codeview] Update comment on aligning symbol records
llvm-svn: 349433
-rw-r--r--llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
index 78e5f5d215b..4132b1a30c4 100644
--- a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
@@ -2831,8 +2831,10 @@ MCSymbol *CodeViewDebug::beginSymbolRecord(SymbolKind SymKind) {
}
void CodeViewDebug::endSymbolRecord(MCSymbol *SymEnd) {
- // Symbol records in object files are not aligned, although we are considering
- // it for linker performance reasons.
+ // MSVC does not pad out symbol records to four bytes, but LLVM does to avoid
+ // an extra copy of every symbol record in LLD. This increases object file
+ // size by less than 1% in the clang build, and is compatible with the Visual
+ // C++ linker.
OS.EmitValueToAlignment(4);
OS.EmitLabel(SymEnd);
}
OpenPOWER on IntegriCloud