diff options
| author | Rui Ueyama <ruiu@google.com> | 2018-02-16 22:58:19 +0000 |
|---|---|---|
| committer | Rui Ueyama <ruiu@google.com> | 2018-02-16 22:58:19 +0000 |
| commit | 4aab7b1d91bd0c9a19b43601fd23e2700d46808a (patch) | |
| tree | cec9b8a3adcec39d224de55621fe3d6816ac695b | |
| parent | f05124e60c804bf919cd688130a96ab7fe61cd1c (diff) | |
| download | bcm5719-llvm-4aab7b1d91bd0c9a19b43601fd23e2700d46808a.tar.gz bcm5719-llvm-4aab7b1d91bd0c9a19b43601fd23e2700d46808a.zip | |
Do not print out "no input files" twice.
Differential Revision: https://reviews.llvm.org/D43408
llvm-svn: 325406
| -rw-r--r-- | lld/test/wasm/driver.ll | 18 | ||||
| -rw-r--r-- | lld/wasm/Driver.cpp | 11 |
2 files changed, 23 insertions, 6 deletions
diff --git a/lld/test/wasm/driver.ll b/lld/test/wasm/driver.ll new file mode 100644 index 00000000000..10a8eca4892 --- /dev/null +++ b/lld/test/wasm/driver.ll @@ -0,0 +1,18 @@ +; RUN: llc -filetype=obj %s -o %t.o + +target triple = "wasm32-unknown-unknown-wasm" + +define hidden void @entry() local_unnamed_addr #0 { +entry: + ret void +} + +; RUN: not wasm-ld -o %t.exe 2>&1 | FileCheck -check-prefix=IN %s +; IN: error: no input files + +; RUN: not wasm-ld %t.o 2>&1 | FileCheck -check-prefix=OUT %s +; OUT: error: no output file specified + +; RUN: not wasm-ld 2>&1 | FileCheck -check-prefix=BOTH %s +; BOTH: error: no input files +; BOTH-NOT: error: no output file specified diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp index 2358aa415e9..8d909ecd69b 100644 --- a/lld/wasm/Driver.cpp +++ b/lld/wasm/Driver.cpp @@ -211,9 +211,6 @@ void LinkerDriver::createFiles(opt::InputArgList &Args) { break; } } - - if (Files.empty()) - error("no input files"); } static StringRef getEntry(opt::InputArgList &Args, StringRef Default) { @@ -280,12 +277,14 @@ void LinkerDriver::link(ArrayRef<const char *> ArgsArr) { if (auto *Arg = Args.getLastArg(OPT_allow_undefined_file)) readImportFile(Arg->getValue()); + if (!Args.hasArg(OPT_INPUT)) { + error("no input files"); + return; + } + if (Config->OutputFile.empty()) error("no output file specified"); - if (!Args.hasArg(OPT_INPUT)) - error("no input files"); - if (Config->Relocatable) { if (!Config->Entry.empty()) error("entry point specified for relocatable output file"); |

