diff options
| author | Sterling Augustine <saugustine@google.com> | 2019-09-20 22:26:55 +0000 |
|---|---|---|
| committer | Sterling Augustine <saugustine@google.com> | 2019-09-20 22:26:55 +0000 |
| commit | 4a58936716e5733662ca1f46734594db0a0e67b9 (patch) | |
| tree | 74a2289f503439a5823350498bc2e3fc06dbf738 | |
| parent | eacbe1cccc40ddd8874fcdbbee2cb9f8a842f4b5 (diff) | |
| download | bcm5719-llvm-4a58936716e5733662ca1f46734594db0a0e67b9.tar.gz bcm5719-llvm-4a58936716e5733662ca1f46734594db0a0e67b9.zip | |
Fix missed case of switching getConstant to getTargetConstant. Try 2.
Summary: This fixes a crasher introduced by r372338.
Reviewers: echristo, arsenm
Subscribers: wdng, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67850
llvm-svn: 372434
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 2 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/isel-blendi-gettargetconstant.ll | 19 |
2 files changed, 20 insertions, 1 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 58af2b37e53..dec3773e1dd 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -17608,7 +17608,7 @@ SDValue X86TargetLowering::LowerINSERT_VECTOR_ELT(SDValue Op, // operand form. N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1); return DAG.getNode(X86ISD::BLENDI, dl, VT, N0, N1, - DAG.getConstant(1, dl, MVT::i8)); + DAG.getTargetConstant(1, dl, MVT::i8)); } // Create this as a scalar to vector.. N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1); diff --git a/llvm/test/CodeGen/X86/isel-blendi-gettargetconstant.ll b/llvm/test/CodeGen/X86/isel-blendi-gettargetconstant.ll new file mode 100644 index 00000000000..b43e2e5a5fb --- /dev/null +++ b/llvm/test/CodeGen/X86/isel-blendi-gettargetconstant.ll @@ -0,0 +1,19 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=sse4.2 | FileCheck %s + +define void @csrot_(float* %0) { +; CHECK-LABEL: csrot_: +; CHECK: # %bb.0: +; CHECK-NEXT: movss {{.*#+}} xmm0 = mem[0],zero,zero,zero +; CHECK-NEXT: movss {{.*#+}} xmm1 = mem[0],zero,zero,zero +; CHECK-NEXT: xorps %xmm0, %xmm1 +; CHECK-NEXT: blendps {{.*#+}} xmm1 = xmm1[0],mem[1,2,3] +; CHECK-NEXT: movlps %xmm1, (%rax) +; CHECK-NEXT: retq +1: + %2 = load float, float* %0, align 4 + %3 = fsub float -0.000000e+00, %2 + %4 = insertelement <2 x float> <float undef, float -0.000000e+00>, float %3, i32 0 + store <2 x float> %4, <2 x float>* undef, align 8 + ret void +} |
