diff options
| author | Michael Gottesman <mgottesman@apple.com> | 2013-03-28 20:11:30 +0000 |
|---|---|---|
| committer | Michael Gottesman <mgottesman@apple.com> | 2013-03-28 20:11:30 +0000 |
| commit | 49f9885a2ac6a5b9bd85d66588fccab0de25923b (patch) | |
| tree | 4a18c40c2d86ef9a626f8f7ca6437764cdc12b01 | |
| parent | 158fdf699e3e25b55e3661518782e47768d5bf9a (diff) | |
| download | bcm5719-llvm-49f9885a2ac6a5b9bd85d66588fccab0de25923b.tar.gz bcm5719-llvm-49f9885a2ac6a5b9bd85d66588fccab0de25923b.zip | |
Non optimizable objc_retainBlock calls are not forwarding.
Since we handle optimizable objc_retainBlocks through strength reduction
in OptimizableIndividualCalls, we know that all code after that point
will only see non-optimizable objc_retainBlock calls. IsForwarding is
only called by functions after that point, so it is ok to just classify
objc_retainBlock as non-forwarding.
<rdar://problem/13249661>.
llvm-svn: 178285
| -rw-r--r-- | llvm/lib/Transforms/ObjCARC/ObjCARC.h | 3 | ||||
| -rw-r--r-- | llvm/test/Transforms/ObjCARC/retain-block.ll | 4 |
2 files changed, 2 insertions, 5 deletions
diff --git a/llvm/lib/Transforms/ObjCARC/ObjCARC.h b/llvm/lib/Transforms/ObjCARC/ObjCARC.h index ba98e0a9c81..614fa29e3e6 100644 --- a/llvm/lib/Transforms/ObjCARC/ObjCARC.h +++ b/llvm/lib/Transforms/ObjCARC/ObjCARC.h @@ -120,13 +120,10 @@ static inline bool IsAutorelease(InstructionClass Class) { /// \brief Test if the given class represents instructions which return their /// argument verbatim. static inline bool IsForwarding(InstructionClass Class) { - // objc_retainBlock technically doesn't always return its argument - // verbatim, but it doesn't matter for our purposes here. return Class == IC_Retain || Class == IC_RetainRV || Class == IC_Autorelease || Class == IC_AutoreleaseRV || - Class == IC_RetainBlock || Class == IC_NoopCast; } diff --git a/llvm/test/Transforms/ObjCARC/retain-block.ll b/llvm/test/Transforms/ObjCARC/retain-block.ll index ee57049d8aa..1bb3f0276ad 100644 --- a/llvm/test/Transforms/ObjCARC/retain-block.ll +++ b/llvm/test/Transforms/ObjCARC/retain-block.ll @@ -98,7 +98,7 @@ entry: ; CHECK-NEXT: tail call i8* @objc_retainBlock(i8* %tmp) [[NUW]] ; CHECK-NEXT: @use_pointer(i8* %tmp2) ; CHECK-NEXT: @use_pointer(i8* %tmp2) -; CHECK-NEXT: tail call void @objc_release(i8* %tmp) [[NUW]], !clang.imprecise_release !0 +; CHECK-NEXT: tail call void @objc_release(i8* %tmp2) [[NUW]], !clang.imprecise_release !0 ; CHECK-NOT: @objc ; CHECK: } define void @test1_no_metadata(i8* %tmp) { @@ -122,7 +122,7 @@ entry: ; CHECK-NEXT: store i8* %tmp2, i8** %z ; CHECK-NEXT: @use_pointer(i8* %tmp2) ; CHECK-NEXT: @use_pointer(i8* %tmp2) -; CHECK-NEXT: tail call void @objc_release(i8* %tmp) [[NUW]], !clang.imprecise_release !0 +; CHECK-NEXT: tail call void @objc_release(i8* %tmp2) [[NUW]], !clang.imprecise_release !0 ; CHECK-NOT: @objc ; CHECK: } define void @test1_escape(i8* %tmp, i8** %z) { |
