diff options
| author | Stella Stamenova <stilis@microsoft.com> | 2018-07-12 21:27:56 +0000 |
|---|---|---|
| committer | Stella Stamenova <stilis@microsoft.com> | 2018-07-12 21:27:56 +0000 |
| commit | 4835a02b80c898b8ad852be2bf425eb5cfd57e82 (patch) | |
| tree | dc51607226990725da04e9c93aa677c0860a49ea | |
| parent | 750dd9f59578dfd73bc43b3690fbe4844a6eae9c (diff) | |
| download | bcm5719-llvm-4835a02b80c898b8ad852be2bf425eb5cfd57e82.tar.gz bcm5719-llvm-4835a02b80c898b8ad852be2bf425eb5cfd57e82.zip | |
[process] Update the documentation for ReadMemory and DoReadMemory to include the error parameter
Summary: The current documentation does not include the error parameter.
Reviewers: jingham, asmith
Reviewed By: jingham
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D49251
llvm-svn: 336948
| -rw-r--r-- | lldb/include/lldb/Target/Process.h | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/lldb/include/lldb/Target/Process.h b/lldb/include/lldb/Target/Process.h index 684e30f7091..66ac5a69252 100644 --- a/lldb/include/lldb/Target/Process.h +++ b/lldb/include/lldb/Target/Process.h @@ -1696,8 +1696,15 @@ public: /// A byte buffer that is at least \a size bytes long that /// will receive the memory bytes. /// + /// @param[out] error + /// An error that indicates the success or failure of this + /// operation. If error indicates success (error.Success()), + /// then the value returned can be trusted, otherwise zero + /// will be returned. + /// /// @return /// The number of bytes that were actually read into \a buf. + /// Zero is returned in the case of an error. //------------------------------------------------------------------ virtual size_t DoReadMemory(lldb::addr_t vm_addr, void *buf, size_t size, Status &error) = 0; @@ -1723,12 +1730,18 @@ public: /// @param[in] size /// The number of bytes to read. /// + /// @param[out] error + /// An error that indicates the success or failure of this + /// operation. If error indicates success (error.Success()), + /// then the value returned can be trusted, otherwise zero + /// will be returned. + /// /// @return /// The number of bytes that were actually read into \a buf. If /// the returned number is greater than zero, yet less than \a /// size, then this function will get called again with \a /// vm_addr, \a buf, and \a size updated appropriately. Zero is - /// returned to indicate an error. + /// returned in the case of an error. //------------------------------------------------------------------ virtual size_t ReadMemory(lldb::addr_t vm_addr, void *buf, size_t size, Status &error); |

