summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Storsjo <martin@martin.st>2018-12-03 20:02:11 +0000
committerMartin Storsjo <martin@martin.st>2018-12-03 20:02:11 +0000
commit44c4c647b4f8bb2f2245c8c4092ebadfc28d47cf (patch)
treeb765be2472b80dfbd409d6ca97650feb31049fe8
parent1aa7e900b331b3709f22ee1163958f49e723c311 (diff)
downloadbcm5719-llvm-44c4c647b4f8bb2f2245c8c4092ebadfc28d47cf.tar.gz
bcm5719-llvm-44c4c647b4f8bb2f2245c8c4092ebadfc28d47cf.zip
[COFF] Remove an outdated/incorrect comment. NFC.
Making the section writable doesn't affect how windows does base relocs in case a DLL can't be loaded at the intended base address. This comment dates back to SVN r79346. Differential Revision: llvm-svn: 348178
-rw-r--r--llvm/lib/MC/MCObjectFileInfo.cpp4
1 files changed, 0 insertions, 4 deletions
diff --git a/llvm/lib/MC/MCObjectFileInfo.cpp b/llvm/lib/MC/MCObjectFileInfo.cpp
index c73a9eb2c9e..be671af1768 100644
--- a/llvm/lib/MC/MCObjectFileInfo.cpp
+++ b/llvm/lib/MC/MCObjectFileInfo.cpp
@@ -510,10 +510,6 @@ void MCObjectFileInfo::initCOFFMCObjectFileInfo(const Triple &T) {
".rdata", COFF::IMAGE_SCN_CNT_INITIALIZED_DATA | COFF::IMAGE_SCN_MEM_READ,
SectionKind::getReadOnly());
- // FIXME: We're emitting LSDA info into a readonly section on COFF, even
- // though it contains relocatable pointers. In PIC mode, this is probably a
- // big runtime hit for C++ apps. Either the contents of the LSDA need to be
- // adjusted or this should be a data section.
if (T.getArch() == Triple::x86_64) {
// On Windows 64 with SEH, the LSDA is emitted into the .xdata section
LSDASection = nullptr;
OpenPOWER on IntegriCloud