Change Expr::isLvalue() to allow the "void" type. This fixes bz2000 submitted by Neil Booth.

Neil, can you point me to the place in the C99 spec that says this is allowed? I thought Expr::isLvalue() conformed to the spec, which says "C99 6.3.2.1: an lvalue is an expression with an object type or an incomplete type other than void.". Please advise.

llvm-svn: 46917

2 files changed, 7 insertions, 4 deletions

diff --git a/clang/AST/Expr.cpp b/clang/AST/Expr.cpp
index f02e817f065..f979c7aa7b5 100644
--- a/clang/AST/Expr.cpp
+++ b/clang/AST/Expr.cpp
@@ -357,9 +357,6 @@ Expr::isLvalueResult Expr::isLvalue() const {
   if (TR->isFunctionType()) // from isObjectType()
     return LV_NotObjectType;
 
-  if (TR->isVoidType())
-    return LV_IncompleteVoidType;
-
   if (TR->isReferenceType()) // C++ [expr]
     return LV_Valid;
 
diff --git a/clang/test/Sema/deref.c b/clang/test/Sema/deref.c
index 7441584107c..7efb55e7205 100644
--- a/clang/test/Sema/deref.c
+++ b/clang/test/Sema/deref.c
@@ -17,6 +17,12 @@ void foo2 (void)
 void foo3 (void)
 {
  void* x = 0;
- void* y = &*x; // expected-error {{address expression must be an lvalue or a function designator}}
+ void* y = &*x;
+}
+
+extern const void cv1;
+const void *foo4 (void)
+{
+  return &cv1;
 }