summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnna Zaks <ganna@apple.com>2012-05-07 17:47:09 +0000
committerAnna Zaks <ganna@apple.com>2012-05-07 17:47:09 +0000
commit41e7ab8f8145081bc4e0abf2838d6d24551c68f9 (patch)
tree5804d5c81eff4939e0d5e1fd9c71e4b9349de38b
parent0ae9efeb1a14a665a0f5d6819e25a83cc6ea348a (diff)
downloadbcm5719-llvm-41e7ab8f8145081bc4e0abf2838d6d24551c68f9.tar.gz
bcm5719-llvm-41e7ab8f8145081bc4e0abf2838d6d24551c68f9.zip
[analyzer]Fixup r156215: use StopTracking summary instead of ScratchArgs
As per Jordy's and Ted's comment, use the default StopTracking summary instead of adding all arguments to ScratchArs. llvm-svn: 156310
-rw-r--r--clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
index 2cf93537712..325a7657e61 100644
--- a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
@@ -1005,10 +1005,8 @@ RetainSummaryManager::getSummary(const FunctionDecl *FD,
ScratchArgs = AF.add(ScratchArgs, 2, StopTracking);
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
} else if (CME && CME->hasNonZeroCallbackArg()) {
- // Allow objects to escape throug callbacks. radar://10973977
- for (unsigned I = 0; I < CME->getNumArgs(); ++I)
- ScratchArgs = AF.add(ScratchArgs, I, StopTracking);
- S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
+ // Allow objects to escape through callbacks. radar://10973977
+ S = getPersistentStopSummary();
}
// Did we get a summary?
OpenPOWER on IntegriCloud