summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTatyana Krasnukha <tatyana@synopsys.com>2019-01-25 18:27:09 +0000
committerTatyana Krasnukha <tatyana@synopsys.com>2019-01-25 18:27:09 +0000
commit414f9b305d8284e6eab6aac1bee814953f67358a (patch)
tree9ed7e425ab0dbd8ba1d75d3825fbd30d71516793
parent76c9877b56b15f4aee1b45643db89db7cf178827 (diff)
downloadbcm5719-llvm-414f9b305d8284e6eab6aac1bee814953f67358a.tar.gz
bcm5719-llvm-414f9b305d8284e6eab6aac1bee814953f67358a.zip
ResolveBreakpointSite: fix outdated warning message
Currently if a breakpoint site is already present, its ID will be returned, not the LLDB_INVALID_BREAK_ID. On the other hand, Process::CreateBreakpointSite may have another reasons to return LLDB_INVALID_BREAK_ID. llvm-svn: 352226
-rw-r--r--lldb/source/Breakpoint/BreakpointLocation.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/lldb/source/Breakpoint/BreakpointLocation.cpp b/lldb/source/Breakpoint/BreakpointLocation.cpp
index 676b61385a7..c337fe647cd 100644
--- a/lldb/source/Breakpoint/BreakpointLocation.cpp
+++ b/lldb/source/Breakpoint/BreakpointLocation.cpp
@@ -454,13 +454,11 @@ bool BreakpointLocation::ResolveBreakpointSite() {
if (new_id == LLDB_INVALID_BREAK_ID) {
Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_BREAKPOINTS);
if (log)
- log->Warning("Tried to add breakpoint site at 0x%" PRIx64
- " but it was already present.\n",
+ log->Warning("Failed to add breakpoint site at 0x%" PRIx64,
m_address.GetOpcodeLoadAddress(&m_owner.GetTarget()));
- return false;
}
- return true;
+ return IsResolved();
}
bool BreakpointLocation::SetBreakpointSite(BreakpointSiteSP &bp_site_sp) {
OpenPOWER on IntegriCloud