diff options
author | Hans Wennborg <hans@hanshq.net> | 2018-10-26 13:05:45 +0000 |
---|---|---|
committer | Hans Wennborg <hans@hanshq.net> | 2018-10-26 13:05:45 +0000 |
commit | 40ccbd315d8707aec785e8bd44e8beb1414366c0 (patch) | |
tree | 106040530da714ecf11fe072b1438ea952b43846 | |
parent | 11c01f402f5d1aa64c80cc803cc1b5391f6b1764 (diff) | |
download | bcm5719-llvm-40ccbd315d8707aec785e8bd44e8beb1414366c0.tar.gz bcm5719-llvm-40ccbd315d8707aec785e8bd44e8beb1414366c0.zip |
Revert r345330 "Add MS ABI mangling for operator<=>."
The generated MS manglings differ between 32- and 64-bit, and the test only
expects the latter. See also the commit email thread.
> Thanks to Cameron DaCamara at Microsoft for letting us know what their
> chosen mangling is here!
llvm-svn: 345380
-rw-r--r-- | clang/lib/AST/MicrosoftMangle.cpp | 11 | ||||
-rw-r--r-- | clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp | 12 | ||||
-rw-r--r-- | clang/test/CodeGenCXX/mangle-ms-cxx2a.cpp | 6 |
3 files changed, 13 insertions, 16 deletions
diff --git a/clang/lib/AST/MicrosoftMangle.cpp b/clang/lib/AST/MicrosoftMangle.cpp index 34e070ab33d..072184d82e8 100644 --- a/clang/lib/AST/MicrosoftMangle.cpp +++ b/clang/lib/AST/MicrosoftMangle.cpp @@ -1240,8 +1240,15 @@ void MicrosoftCXXNameMangler::mangleOperatorName(OverloadedOperatorKind OO, case OO_Array_Delete: Out << "?_V"; break; // <operator-name> ::= ?__L # co_await case OO_Coawait: Out << "?__L"; break; - // <operator-name> ::= ?__M # <=> - case OO_Spaceship: Out << "?__M"; break; + + case OO_Spaceship: { + // FIXME: Once MS picks a mangling, use it. + DiagnosticsEngine &Diags = Context.getDiags(); + unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error, + "cannot mangle this three-way comparison operator yet"); + Diags.Report(Loc, DiagID); + break; + } case OO_Conditional: { DiagnosticsEngine &Diags = Context.getDiags(); diff --git a/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp b/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp index 827b2005b0c..fd72d4a39cb 100644 --- a/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp +++ b/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp @@ -1,28 +1,24 @@ -// RUN: %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %itanium_abi_triple | FileCheck %s --check-prefixes=CHECK,ITANIUM -// RUN: %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %ms_abi_triple | FileCheck %s --check-prefixes=CHECK,MSABI +// RUN: %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %itanium_abi_triple | FileCheck %s --check-prefix=ITANIUM +// RUN: not %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %ms_abi_triple 2>&1 | FileCheck %s --check-prefix=MSABI // RUN: not %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %itanium_abi_triple -DBUILTIN 2>&1 | FileCheck %s --check-prefix=BUILTIN -// RUN: not %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %ms_abi_triple -DBUILTIN 2>&1 | FileCheck %s --check-prefix=BUILTIN +// MSABI: cannot mangle this three-way comparison operator yet struct A { void operator<=>(int); }; // ITANIUM: define {{.*}}@_ZN1AssEi( -// MSABI: define {{.*}}@"??__MA@@QEAAXH@Z"( void A::operator<=>(int) {} // ITANIUM: define {{.*}}@_Zssi1A( -// MSABI: define {{.*}}@"??__M@YAXHUA@@@Z"( void operator<=>(int, A) {} int operator<=>(A, A); // ITANIUM: define {{.*}}_Z1f1A( -// MSABI: define {{.*}}"?f@@YAHUA@@@Z"( int f(A a) { // ITANIUM: %[[RET:.*]] = call {{.*}}_Zss1AS_( - // MSABI: %[[RET:.*]] = call {{.*}}"??__M@YAHUA@@0@Z"( - // CHECK: ret i32 %[[RET]] + // ITANIUM: ret i32 %[[RET]] return a <=> a; } diff --git a/clang/test/CodeGenCXX/mangle-ms-cxx2a.cpp b/clang/test/CodeGenCXX/mangle-ms-cxx2a.cpp deleted file mode 100644 index a185e99cd49..00000000000 --- a/clang/test/CodeGenCXX/mangle-ms-cxx2a.cpp +++ /dev/null @@ -1,6 +0,0 @@ -// RUN: %clang_cc1 -std=c++2a -fms-extensions -emit-llvm %s -o - -triple=i386-pc-win32 -fms-compatibility-version=19.00 | FileCheck %s - -struct A {}; - -// CHECK-DAG: define {{.*}} @"??__M@YAXUA@@0@Z" -void operator<=>(A, A) {} |