summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSam McCall <sam.mccall@gmail.com>2018-11-02 12:51:26 +0000
committerSam McCall <sam.mccall@gmail.com>2018-11-02 12:51:26 +0000
commit3fd25fcf36aaf7945f1669bce4f5aa5c9bf36bb6 (patch)
treed080915b11521910b0ee05d6e8d0142c70a4bae7
parent7a2a27c4a49de60ceb84f281e78077059a99ce7e (diff)
downloadbcm5719-llvm-3fd25fcf36aaf7945f1669bce4f5aa5c9bf36bb6.tar.gz
bcm5719-llvm-3fd25fcf36aaf7945f1669bce4f5aa5c9bf36bb6.zip
[clangd] Only log ignored diagnostics with -log=verbose.
Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Revision: https://reviews.llvm.org/D53648 llvm-svn: 345968
-rw-r--r--clang-tools-extra/clangd/Compiler.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/clang-tools-extra/clangd/Compiler.cpp b/clang-tools-extra/clangd/Compiler.cpp
index 2aecadd4ed8..011841c4613 100644
--- a/clang-tools-extra/clangd/Compiler.cpp
+++ b/clang-tools-extra/clangd/Compiler.cpp
@@ -20,6 +20,7 @@ namespace clangd {
void IgnoreDiagnostics::log(DiagnosticsEngine::Level DiagLevel,
const clang::Diagnostic &Info) {
+ // FIXME: format lazily, in case vlog is off.
SmallString<64> Message;
Info.FormatDiagnostic(Message);
@@ -32,7 +33,7 @@ void IgnoreDiagnostics::log(DiagnosticsEngine::Level DiagLevel,
OS << ":";
}
- clangd::log("Ignored diagnostic. {0}{1}", Location, Message);
+ clangd::vlog("Ignored diagnostic. {0}{1}", Location, Message);
}
void IgnoreDiagnostics::HandleDiagnostic(DiagnosticsEngine::Level DiagLevel,
OpenPOWER on IntegriCloud