summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChen Li <meloli87@gmail.com>2015-07-15 22:41:13 +0000
committerChen Li <meloli87@gmail.com>2015-07-15 22:41:13 +0000
commit3f5ed1566e34e7d2a83fb98bead1079e37b52579 (patch)
tree62fae7616e5f06954826b08eab4f3c63acc3020b
parentac351b7943ebfd90ec3df2645454a4ce1bc0f0a4 (diff)
downloadbcm5719-llvm-3f5ed1566e34e7d2a83fb98bead1079e37b52579.tar.gz
bcm5719-llvm-3f5ed1566e34e7d2a83fb98bead1079e37b52579.zip
[LoopUnswitch] Add an else clause to IsTrivialUnswitchCondition() when checking HeaderTerm instruction type
Summary: This is a trivial code change with no functionality effect. When LoopUnswitch determines trivial unswitch condition, it checks whether the loop header's terminator instruction is a branch instruction or switch instruction since trivial unswitch condition can only apply to these two instruction types. The current code does not fail the check directly on other instruction types, but check the nullness of LoopExitBB variable instead. The added else clause makes the check fail immediately on other instruction types and makes the code more obvious. Reviewers: reames Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D11239 llvm-svn: 242345
-rw-r--r--llvm/lib/Transforms/Scalar/LoopUnswitch.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
index cbc563bd899..ce167d1c657 100644
--- a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
@@ -641,7 +641,8 @@ bool LoopUnswitch::IsTrivialUnswitchCondition(Value *Cond, Constant **Val,
break;
}
}
- }
+ } else
+ return false;
// If we didn't find a single unique LoopExit block, or if the loop exit block
// contains phi nodes, this isn't trivial.
OpenPOWER on IntegriCloud