diff options
| author | Tim Shen <timshen91@gmail.com> | 2016-08-25 21:03:46 +0000 |
|---|---|---|
| committer | Tim Shen <timshen91@gmail.com> | 2016-08-25 21:03:46 +0000 |
| commit | 3ad8b43cc279b385fa19728aa0b0cbc52694b931 (patch) | |
| tree | 139aa159e390d2924f7bab9a494e6b87244316a3 | |
| parent | 6ac9172934748a4a9e6ec4bd97152271eede40b5 (diff) | |
| download | bcm5719-llvm-3ad8b43cc279b385fa19728aa0b0cbc52694b931.tar.gz bcm5719-llvm-3ad8b43cc279b385fa19728aa0b0cbc52694b931.zip | |
[MemCpy] Add comments for r279769
Differential Revision: https://reviews.llvm.org/D23846
llvm-svn: 279778
| -rw-r--r-- | llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp | 3 | ||||
| -rw-r--r-- | llvm/test/Transforms/MemCpyOpt/pr29105.ll | 1 |
2 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp b/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp index 27c37cd5289..c6e8cde8f47 100644 --- a/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp +++ b/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp @@ -1110,7 +1110,8 @@ bool MemCpyOptPass::performMemCpyToMemSetOptzn(MemCpyInst *MemCpy, MemSetInst *MemSet) { AliasAnalysis &AA = LookupAliasAnalysis(); - // This only makes sense on memcpy(..., memset(...), ...). + // Make sure that memcpy(..., memset(...), ...), that is we are memsetting and + // memcpying from the same address. Otherwise it is hard to reason about. if (!AA.isMustAlias(MemSet->getRawDest(), MemCpy->getRawSource())) return false; diff --git a/llvm/test/Transforms/MemCpyOpt/pr29105.ll b/llvm/test/Transforms/MemCpyOpt/pr29105.ll index ad9f97e7a23..0d377837226 100644 --- a/llvm/test/Transforms/MemCpyOpt/pr29105.ll +++ b/llvm/test/Transforms/MemCpyOpt/pr29105.ll @@ -1,6 +1,7 @@ ; RUN: opt -memcpyopt -instcombine -S %s | FileCheck %s %Foo = type { [2048 x i64] } +; Make sure that all mempcy calls are converted to memset calls, or removed. ; CHECK-LABEL: @baz( ; CHECK-NOT: call void @llvm.memcpy define void @baz() unnamed_addr #0 { |
