summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavide Italiano <davide@freebsd.org>2016-09-13 18:45:13 +0000
committerDavide Italiano <davide@freebsd.org>2016-09-13 18:45:13 +0000
commit39ccd24126fcb99e95f15e49278a88adece2319a (patch)
tree597429f68b2153f06292667de1c73718b1fe40b6
parent9bf66f70cbc0f304e3eef68bc725a0e2f82ee0e4 (diff)
downloadbcm5719-llvm-39ccd24126fcb99e95f15e49278a88adece2319a.tar.gz
bcm5719-llvm-39ccd24126fcb99e95f15e49278a88adece2319a.zip
[LTO] Don't pass SF_Undefined symbols to the IRmover.
This should fix PR 30363. llvm-svn: 281366
-rw-r--r--llvm/lib/LTO/LTO.cpp2
-rw-r--r--llvm/test/tools/gold/X86/asm_undefined.ll18
2 files changed, 20 insertions, 0 deletions
diff --git a/llvm/lib/LTO/LTO.cpp b/llvm/lib/LTO/LTO.cpp
index f495774b033..0323bb83858 100644
--- a/llvm/lib/LTO/LTO.cpp
+++ b/llvm/lib/LTO/LTO.cpp
@@ -337,6 +337,8 @@ Error LTO::addRegularLTO(std::unique_ptr<InputFile> Input,
addSymbolToGlobalRes(Obj.get(), Used, Sym, Res, 0);
GlobalValue *GV = Obj->getSymbolGV(Sym.I->getRawDataRefImpl());
+ if (Sym.getFlags() & object::BasicSymbolRef::SF_Undefined)
+ continue;
if (Res.Prevailing && GV) {
Keep.push_back(GV);
switch (GV->getLinkage()) {
diff --git a/llvm/test/tools/gold/X86/asm_undefined.ll b/llvm/test/tools/gold/X86/asm_undefined.ll
new file mode 100644
index 00000000000..6e889a0e372
--- /dev/null
+++ b/llvm/test/tools/gold/X86/asm_undefined.ll
@@ -0,0 +1,18 @@
+; RUN: llvm-as %s -o %t.o
+; RUN: %gold -shared -m elf_x86_64 -o %t2 -plugin %llvmshlibdir/LLVMgold.so \
+; RUN: %t.o --plugin-opt=save-temps
+; RUN: llvm-nm %t2 | FileCheck %s --check-prefix=OUTPUT
+
+; OUTPUT: w patatino
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+module asm ".weak patatino"
+
+declare void @patatino()
+
+define void @_start() {
+ call void @patatino()
+ ret void
+}
OpenPOWER on IntegriCloud