diff options
author | Manoj Gupta <manojgupta@google.com> | 2019-09-13 00:28:37 +0000 |
---|---|---|
committer | Manoj Gupta <manojgupta@google.com> | 2019-09-13 00:28:37 +0000 |
commit | 38f6b3fd8dd7dc3a3b4eae63738d5d3a741b2227 (patch) | |
tree | 20627a342c5ad7f8faeaca5785ec740aea233d80 | |
parent | 4a73c6eadae0c92771106f85fc77c32f60a1b30e (diff) | |
download | bcm5719-llvm-38f6b3fd8dd7dc3a3b4eae63738d5d3a741b2227.tar.gz bcm5719-llvm-38f6b3fd8dd7dc3a3b4eae63738d5d3a741b2227.zip |
Revert r371785.
r371785 is causing fails on clang-hexagon-elf buildbots.
llvm-svn: 371799
8 files changed, 0 insertions, 39 deletions
diff --git a/clang/include/clang/Basic/DiagnosticCommonKinds.td b/clang/include/clang/Basic/DiagnosticCommonKinds.td index 1cd62d1e138..8196a4601c2 100644 --- a/clang/include/clang/Basic/DiagnosticCommonKinds.td +++ b/clang/include/clang/Basic/DiagnosticCommonKinds.td @@ -315,9 +315,4 @@ def err_unknown_analyzer_checker_or_package : Error< "no analyzer checkers or packages are associated with '%0'">; def note_suggest_disabling_all_checkers : Note< "use -analyzer-disable-all-checks to disable all static analyzer checkers">; - -// Poison system directories. -def warn_poison_system_directories : Warning < - "include location '%0' is unsafe for cross-compilation">, - InGroup<DiagGroup<"poison-system-directories">>, DefaultIgnore; } diff --git a/clang/lib/Frontend/InitHeaderSearch.cpp b/clang/lib/Frontend/InitHeaderSearch.cpp index 5d877ee9c0d..ad0d2327148 100644 --- a/clang/lib/Frontend/InitHeaderSearch.cpp +++ b/clang/lib/Frontend/InitHeaderSearch.cpp @@ -137,13 +137,6 @@ bool InitHeaderSearch::AddUnmappedPath(const Twine &Path, IncludeDirGroup Group, SmallString<256> MappedPathStorage; StringRef MappedPathStr = Path.toStringRef(MappedPathStorage); - // If use system headers while cross-compiling, emit the warning. - if (HasSysroot && (MappedPathStr.startswith("/usr/include") || - MappedPathStr.startswith("/usr/local/include"))) { - Headers.getDiags().Report(diag::warn_poison_system_directories) - << MappedPathStr; - } - // Compute the DirectoryLookup type. SrcMgr::CharacteristicKind Type; if (Group == Quoted || Group == Angled || Group == IndexHeaderMap) { diff --git a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/lib/.keep b/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/lib/.keep deleted file mode 100644 index e69de29bb2d..00000000000 --- a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/lib/.keep +++ /dev/null diff --git a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/include/c++/.keep b/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/include/c++/.keep deleted file mode 100644 index e69de29bb2d..00000000000 --- a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/include/c++/.keep +++ /dev/null diff --git a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/lib/gcc/.keep b/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/lib/gcc/.keep deleted file mode 100644 index e69de29bb2d..00000000000 --- a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/lib/gcc/.keep +++ /dev/null diff --git a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/local/include/.keep b/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/local/include/.keep deleted file mode 100644 index e69de29bb2d..00000000000 --- a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/local/include/.keep +++ /dev/null diff --git a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/local/lib/.keep b/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/local/lib/.keep deleted file mode 100644 index e69de29bb2d..00000000000 --- a/clang/test/Frontend/Inputs/sysroot_x86_64_cross_linux_tree/usr/local/lib/.keep +++ /dev/null diff --git a/clang/test/Frontend/warning-poison-system-directories.c b/clang/test/Frontend/warning-poison-system-directories.c deleted file mode 100644 index 018f02db361..00000000000 --- a/clang/test/Frontend/warning-poison-system-directories.c +++ /dev/null @@ -1,27 +0,0 @@ -// System directory and sysroot option causes warning. -// RUN: %clang -Wpoison-system-directories -target x86_64 -I/usr/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tree -c -o - %s 2> %t.1.stderr -// RUN: FileCheck -check-prefix=WARN < %t.1.stderr %s -// RUN: %clang -Wpoison-system-directories -target x86_64 -cxx-isystem/usr/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tree -c -o - %s 2> %t.1.stderr -// RUN: FileCheck -check-prefix=WARN < %t.1.stderr %s -// RUN: %clang -Wpoison-system-directories -target x86_64 -iquote/usr/local/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tree -c -o - %s 2> %t.1.stderr -// RUN: FileCheck -check-prefix=WARN < %t.1.stderr %s -// RUN: %clang -Wpoison-system-directories -target x86_64 -isystem/usr/local/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tree -c -o - %s 2> %t.1.stderr -// RUN: FileCheck -check-prefix=WARN < %t.1.stderr %s - -// Missing target but included sysroot still causes the warning. -// RUN: %clang -Wpoison-system-directories -I/usr/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tree -c -o - %s 2> %t.2.stderr -// RUN: FileCheck -check-prefix=WARN < %t.2.stderr %s - -// With -Werror the warning causes the failure. -// RUN: not %clang -Werror=poison-system-directories -target x86_64 -I/usr/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tree -c -o - %s 2> %t.3.stderr -// RUN: FileCheck -check-prefix=ERROR < %t.3.stderr %s - -// Cros target without sysroot causes no warning. -// RUN: %clang -Wpoison-system-directories -Werror -target x86_64 -I/usr/include -c -o - %s - -// By default the warning is off. -// RUN: %clang -Werror -target x86_64 -I/usr/include --sysroot %S/Inputs/sysroot_x86_64_cross_linux_tree -c -o - %s - -// WARN: warning: include location {{[^ ]+}} is unsafe for cross-compilation [-Wpoison-system-directories] - -// ERROR: error: include location {{[^ ]+}} is unsafe for cross-compilation [-Werror,-Wpoison-system-directories] |