summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2018-08-07 23:48:25 +0000
committerVedant Kumar <vsk@apple.com>2018-08-07 23:48:25 +0000
commit33e51b142c4f7402c7297758c6ea3f32357d2728 (patch)
tree102601085c698f560f62afabeb284f18731a295f
parentab48bd2a8d4186422b9f44dccb5c6f53c9c7532c (diff)
downloadbcm5719-llvm-33e51b142c4f7402c7297758c6ea3f32357d2728.tar.gz
bcm5719-llvm-33e51b142c4f7402c7297758c6ea3f32357d2728.zip
[StackFrame] Add more clarifying comments to StackFrameList (NFC)
llvm-svn: 339205
-rw-r--r--lldb/source/Target/StackFrameList.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Target/StackFrameList.cpp b/lldb/source/Target/StackFrameList.cpp
index 595e1aaa7d5..f177df0ccdf 100644
--- a/lldb/source/Target/StackFrameList.cpp
+++ b/lldb/source/Target/StackFrameList.cpp
@@ -234,6 +234,9 @@ void StackFrameList::GetOnlyConcreteFramesUpTo(uint32_t end_idx,
// Done unwinding.
m_concrete_frames_fetched = UINT32_MAX;
}
+
+ // Don't create the frames eagerly. Defer this work to GetFrameAtIndex,
+ // which can lazily query the unwinder to create frames.
m_frames.resize(num_frames);
}
@@ -567,9 +570,6 @@ StackFrameSP StackFrameList::GetFrameWithStackID(const StackID &stack_id) {
if ((*pos)->GetStackID() == stack_id)
return *pos;
}
-
- // if (m_frames.back()->GetStackID() < stack_id)
- // frame_idx = m_frames.size();
}
do {
frame_sp = GetFrameAtIndex(frame_idx);
OpenPOWER on IntegriCloud