diff options
| author | Bruno Cardoso Lopes <bruno.cardoso@gmail.com> | 2011-09-14 02:36:14 +0000 |
|---|---|---|
| committer | Bruno Cardoso Lopes <bruno.cardoso@gmail.com> | 2011-09-14 02:36:14 +0000 |
| commit | 333a59eced18579363b7d11a04f97bca6553edc7 (patch) | |
| tree | 3d63359383bf90cc9b26691dc5ed5ad8e77263ff | |
| parent | a9e7fb678d2c391d68a262cd614b76d3e305d71e (diff) | |
| download | bcm5719-llvm-333a59eced18579363b7d11a04f97bca6553edc7.tar.gz bcm5719-llvm-333a59eced18579363b7d11a04f97bca6553edc7.zip | |
Vector shuffle mask <i32 4, i32 5, i32 2, i32 3> should yield "movsd", not "movss".
llvm-svn: 139686
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 4 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/vec_shuffle-38.ll | 14 |
2 files changed, 17 insertions, 1 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 988b55739e0..0839ecd1755 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -6348,7 +6348,9 @@ SDValue getMOVLP(SDValue &Op, DebugLoc &dl, SelectionDAG &DAG, bool HasSSE2) { // matching to x86 specific nodes. Note that for the 1st condition all // types are matched with movsd. if (HasSSE2) { - if (NumElems == 2) + // FIXME: isMOVLMask should be checked and matched before getMOVLP, + // as to remove this logic from here, as much as possible + if (NumElems == 2 || !X86::isMOVLMask(SVOp)) return getTargetShuffleNode(X86ISD::MOVSD, dl, VT, V1, V2, DAG); return getTargetShuffleNode(X86ISD::MOVSS, dl, VT, V1, V2, DAG); } diff --git a/llvm/test/CodeGen/X86/vec_shuffle-38.ll b/llvm/test/CodeGen/X86/vec_shuffle-38.ll index 978f59eec71..69a2ede758a 100644 --- a/llvm/test/CodeGen/X86/vec_shuffle-38.ll +++ b/llvm/test/CodeGen/X86/vec_shuffle-38.ll @@ -43,3 +43,17 @@ entry: %shuffle = shufflevector <4 x float> %vecin1, <4 x float> %vecin2, <4 x i32> <i32 0, i32 1, i32 4, i32 5> ret <4 x float> %shuffle } + +; rdar://10119696 +; CHECK: f +define <4 x float> @f(<4 x float> %x, double* nocapture %y) nounwind uwtable readonly ssp { +entry: + ; CHECK: movsd (% + ; CHECK-NEXT: movsd %xmm + %u110.i = load double* %y, align 1 + %tmp8.i = insertelement <2 x double> undef, double %u110.i, i32 0 + %tmp9.i = bitcast <2 x double> %tmp8.i to <4 x float> + %shuffle.i = shufflevector <4 x float> %x, <4 x float> %tmp9.i, <4 x i32> <i32 4, i32 5, i32 2, i32 3> + ret <4 x float> %shuffle.i +} + |
