diff options
| author | Enrico Granata <egranata@apple.com> | 2012-03-09 19:04:53 +0000 |
|---|---|---|
| committer | Enrico Granata <egranata@apple.com> | 2012-03-09 19:04:53 +0000 |
| commit | 332b0b9a2fe13b11df3b78520ef66b9850a88f3b (patch) | |
| tree | 5e1a5644c345b74cbe527991d813b388c9f86958 | |
| parent | 3a08300585217c73900f6204524d43adbc23164f (diff) | |
| download | bcm5719-llvm-332b0b9a2fe13b11df3b78520ef66b9850a88f3b.tar.gz bcm5719-llvm-332b0b9a2fe13b11df3b78520ef66b9850a88f3b.zip | |
Fixing a problem with the NSSet summary provider; plus, providing a further optimization to the whole Cocoa formatters infrastructure
llvm-svn: 152423
| -rw-r--r-- | lldb/examples/summaries/cocoa/NSSet.py | 2 | ||||
| -rw-r--r-- | lldb/examples/summaries/cocoa/metrics.py | 6 |
2 files changed, 6 insertions, 2 deletions
diff --git a/lldb/examples/summaries/cocoa/NSSet.py b/lldb/examples/summaries/cocoa/NSSet.py index b1f65053415..4abf703e1a9 100644 --- a/lldb/examples/summaries/cocoa/NSSet.py +++ b/lldb/examples/summaries/cocoa/NSSet.py @@ -189,7 +189,7 @@ def GetSummary_Impl(valobj): wrapper = NSCountedSet_SummaryProvider(valobj, class_data.sys_params) statistics.metric_hit('code_notrun',valobj) else: - wrapper = NSSetUnknown_SummaryProvider(valobj) + wrapper = NSSetUnknown_SummaryProvider(valobj, class_data.sys_params) statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string) return wrapper; diff --git a/lldb/examples/summaries/cocoa/metrics.py b/lldb/examples/summaries/cocoa/metrics.py index bf9a025d183..99489e147e9 100644 --- a/lldb/examples/summaries/cocoa/metrics.py +++ b/lldb/examples/summaries/cocoa/metrics.py @@ -6,7 +6,11 @@ class Counter: self.list = [] def update(self,name): self.count = self.count + 1 - self.list.append(str(name)) + # avoid getting the full dump of this ValueObject just to save its metrics + if isinstance(name,lldb.SBValue): + self.list.append(name.GetName()) + else: + self.list.append(str(name)) def __str__(self): return str(self.count) + " times, for items [" + str(self.list) + "]" |
