summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2009-03-09 05:52:15 +0000
committerChris Lattner <sabre@nondot.org>2009-03-09 05:52:15 +0000
commit317293b504e5ef3e65e3dacc645fa465359adc26 (patch)
tree27d25532e40dc00a0dc4213183a4970879fda188
parent6f884e07c57809d8a3af4f6374797fbfaf019382 (diff)
downloadbcm5719-llvm-317293b504e5ef3e65e3dacc645fa465359adc26.tar.gz
bcm5719-llvm-317293b504e5ef3e65e3dacc645fa465359adc26.zip
Make the code generator rip of dead constant expr uses before deciding
whether a global is dead or not. This should fix PR3749 - linker adds spurious use to appending globals. I can't reasonably add a testcase for this, because the bc writer/reader strip dead constant users. llvm-svn: 66404
-rw-r--r--llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp26
1 files changed, 16 insertions, 10 deletions
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index fd71ba971e7..dcfa7a5961d 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -418,18 +418,24 @@ bool AsmPrinter::EmitSpecialLLVMGlobal(const GlobalVariable *GV) {
const TargetData *TD = TM.getTargetData();
unsigned Align = Log2_32(TD->getPointerPrefAlignment());
- if (GV->getName() == "llvm.global_ctors" && GV->use_empty()) {
- SwitchToDataSection(TAI->getStaticCtorsSection());
- EmitAlignment(Align, 0);
- EmitXXStructorList(GV->getInitializer());
- return true;
+ if (GV->getName() == "llvm.global_ctors") {
+ GV->removeDeadConstantUsers();
+ if (GV->use_empty()) {
+ SwitchToDataSection(TAI->getStaticCtorsSection());
+ EmitAlignment(Align, 0);
+ EmitXXStructorList(GV->getInitializer());
+ return true;
+ }
}
- if (GV->getName() == "llvm.global_dtors" && GV->use_empty()) {
- SwitchToDataSection(TAI->getStaticDtorsSection());
- EmitAlignment(Align, 0);
- EmitXXStructorList(GV->getInitializer());
- return true;
+ if (GV->getName() == "llvm.global_dtors") {
+ GV->removeDeadConstantUsers();
+ if (GV->use_empty()) {
+ SwitchToDataSection(TAI->getStaticDtorsSection());
+ EmitAlignment(Align, 0);
+ EmitXXStructorList(GV->getInitializer());
+ return true;
+ }
}
return false;
OpenPOWER on IntegriCloud