summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDale Johannesen <dalej@apple.com>2009-06-22 20:59:07 +0000
committerDale Johannesen <dalej@apple.com>2009-06-22 20:59:07 +0000
commit315fb72d361a41282a0dc03eb980c9d31a803114 (patch)
tree0d0663f35a0a3451eb710146e47a76dee884e266
parent0b6a6242ede6620b90c8b1d5db1c85e5cb29d91c (diff)
downloadbcm5719-llvm-315fb72d361a41282a0dc03eb980c9d31a803114.tar.gz
bcm5719-llvm-315fb72d361a41282a0dc03eb980c9d31a803114.zip
Fix memcpy expansion so it won't generate invalid
types for the target (I think). This was breaking the PPC32 calling sequence. llvm-svn: 73900
-rw-r--r--llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp31
1 files changed, 25 insertions, 6 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index a9adce8fdc5..ce01d53d60e 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -3121,6 +3121,8 @@ bool MeetsMaxMemopRequirement(std::vector<MVT> &MemOps,
VT = (MVT::SimpleValueType)(VT.getSimpleVT() - 1);
VTSize = VT.getSizeInBits() / 8;
} else {
+ // This can result in a type that is not legal on the target, e.g.
+ // 1 or 2 bytes on PPC.
VT = (MVT::SimpleValueType)(VT.getSimpleVT() - 1);
VTSize >>= 1;
}
@@ -3177,12 +3179,29 @@ static SDValue getMemcpyLoadsAndStores(SelectionDAG &DAG, DebugLoc dl,
getMemBasePlusOffset(Dst, DstOff, DAG),
DstSV, DstSVOff + DstOff, false, DstAlign);
} else {
- Value = DAG.getLoad(VT, dl, Chain,
- getMemBasePlusOffset(Src, SrcOff, DAG),
- SrcSV, SrcSVOff + SrcOff, false, Align);
- Store = DAG.getStore(Chain, dl, Value,
- getMemBasePlusOffset(Dst, DstOff, DAG),
- DstSV, DstSVOff + DstOff, false, DstAlign);
+ // The type might not be legal for the target. This should only happen
+ // if the type is smaller than a legal type, as on PPC, so the right
+ // thing to do is generate a LoadExt/StoreTrunc pair.
+ // FIXME does the case above also need this?
+ if (TLI.isTypeLegal(VT)) {
+ Value = DAG.getLoad(VT, dl, Chain,
+ getMemBasePlusOffset(Src, SrcOff, DAG),
+ SrcSV, SrcSVOff + SrcOff, false, Align);
+ Store = DAG.getStore(Chain, dl, Value,
+ getMemBasePlusOffset(Dst, DstOff, DAG),
+ DstSV, DstSVOff + DstOff, false, DstAlign);
+ } else {
+ MVT NVT = VT;
+ while (!TLI.isTypeLegal(NVT)) {
+ NVT = (MVT::SimpleValueType(NVT.getSimpleVT() + 1));
+ }
+ Value = DAG.getExtLoad(ISD::EXTLOAD, dl, NVT, Chain,
+ getMemBasePlusOffset(Src, SrcOff, DAG),
+ SrcSV, SrcSVOff + SrcOff, VT, false, Align);
+ Store = DAG.getTruncStore(Chain, dl, Value,
+ getMemBasePlusOffset(Dst, DstOff, DAG),
+ DstSV, DstSVOff + DstOff, VT, false, DstAlign);
+ }
}
OutChains.push_back(Store);
SrcOff += VTSize;
OpenPOWER on IntegriCloud