diff options
| author | Louis Dionne <ldionne@apple.com> | 2019-03-14 14:38:38 +0000 |
|---|---|---|
| committer | Louis Dionne <ldionne@apple.com> | 2019-03-14 14:38:38 +0000 |
| commit | 30f305efe27928b15d24c7670cce54d26dd2e348 (patch) | |
| tree | 93e6b172757eab332a03409a10f03d46589b29d5 | |
| parent | f5fe2974cfd2dde5d0c9d98428fce5b3f5d3955a (diff) | |
| download | bcm5719-llvm-30f305efe27928b15d24c7670cce54d26dd2e348.tar.gz bcm5719-llvm-30f305efe27928b15d24c7670cce54d26dd2e348.zip | |
[libc++] Do not force building with -fPIC (re-applying)
Summary:
In r355746, we stopped forcing to build with -fPIC because that should
be specified by the CMAKE_POSITION_INDEPENDENT_CODE option at CMake
configure time (and by default -fPIC is used for shared libraries anyways).
However, r355746 had to be reverted in r355756 because we were not
actually building the shared library with -fPIC. The reason is that
we were sharing an object library between the static and the shared
library, which caused flags for static libraries to be used when
building object files that were going to be used for a shared library.
Since this was resolved by r356150, we can stop forcing -fPIC again.
Reviewers: EricWF, smeenai
Subscribers: mgorny, christof, jkorous, dexonsmith, libcxx-commits
Differential Revision: https://reviews.llvm.org/D59250
llvm-svn: 356153
| -rw-r--r-- | libcxx/lib/CMakeLists.txt | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/libcxx/lib/CMakeLists.txt b/libcxx/lib/CMakeLists.txt index b8cb14a2796..89485d73440 100644 --- a/libcxx/lib/CMakeLists.txt +++ b/libcxx/lib/CMakeLists.txt @@ -105,10 +105,6 @@ if (LIBCXXABI_USE_LLVM_UNWINDER) endif() # Setup flags. -if (NOT WIN32) - add_flags_if_supported(-fPIC) -endif() - add_link_flags_if_supported(-nodefaultlibs) if (LIBCXX_TARGETING_MSVC) |
