summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJim Ingham <jingham@apple.com>2017-12-02 00:11:18 +0000
committerJim Ingham <jingham@apple.com>2017-12-02 00:11:18 +0000
commit2f1cb7ed82e2e377008de69fc2c6916ce9cac8f3 (patch)
tree4d61fe9ba832871e99ac8b7b6fb333d8ea440d3b
parent1541c37cb972b08fe4d99849cd9ca226a6f6b7e4 (diff)
downloadbcm5719-llvm-2f1cb7ed82e2e377008de69fc2c6916ce9cac8f3.tar.gz
bcm5719-llvm-2f1cb7ed82e2e377008de69fc2c6916ce9cac8f3.zip
Don't use llvm::EnablePrettyStackTrace on macOS.
LLDB.framework gets loaded into Xcode and other frameworks, and this is inserting a signal handler into the process even when lldb isn't used. I have a bunch of reports of this SignalHandler blowing out the stack, which renders crash reports for the crash useless. And in any case libraries really shouldn't be installing signal handlers. I only turned this off for APPLE platforms, I'll let the maintainers of other platforms decide what policy they want to have w.r.t. this. llvm-svn: 319598
-rw-r--r--lldb/source/Initialization/SystemInitializerCommon.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/lldb/source/Initialization/SystemInitializerCommon.cpp b/lldb/source/Initialization/SystemInitializerCommon.cpp
index 853547051ff..a8fc46c119d 100644
--- a/lldb/source/Initialization/SystemInitializerCommon.cpp
+++ b/lldb/source/Initialization/SystemInitializerCommon.cpp
@@ -69,7 +69,9 @@ void SystemInitializerCommon::Initialize() {
}
#endif
+#if not defined(__APPLE__)
llvm::EnablePrettyStackTrace();
+#endif
Log::Initialize();
HostInfo::Initialize();
static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
OpenPOWER on IntegriCloud