diff options
| author | Ted Kremenek <kremenek@apple.com> | 2008-05-06 04:28:05 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2008-05-06 04:28:05 +0000 |
| commit | 2f08fedec1f4c6f92ff4afb4aeda07bc36d953aa (patch) | |
| tree | 1fcf40408e24e9c78b3af3052a305405d12b4a7b | |
| parent | 041d02201f02b407db70183f234f072fdb2eb6d7 (diff) | |
| download | bcm5719-llvm-2f08fedec1f4c6f92ff4afb4aeda07bc36d953aa.tar.gz bcm5719-llvm-2f08fedec1f4c6f92ff4afb4aeda07bc36d953aa.zip | |
String comparison cleanups.
Added test case.
llvm-svn: 50711
| -rw-r--r-- | clang/lib/Analysis/CFRefCount.cpp | 2 | ||||
| -rw-r--r-- | clang/test/Analysis-Apple/CFDate.m | 11 |
2 files changed, 12 insertions, 1 deletions
diff --git a/clang/lib/Analysis/CFRefCount.cpp b/clang/lib/Analysis/CFRefCount.cpp index 040445b20bc..4a20fbec87f 100644 --- a/clang/lib/Analysis/CFRefCount.cpp +++ b/clang/lib/Analysis/CFRefCount.cpp @@ -636,7 +636,7 @@ RetainSummaryManager::getInstanceMethodSummary(IdentifierInfo* ClsName, if (s[0] == '\0') break; - if (s[0]!='W' || s[1]!='i' || s[2]!='t' || s[3]!='h') + if (!strncmp(s, "With", 4)) break; return 0; diff --git a/clang/test/Analysis-Apple/CFDate.m b/clang/test/Analysis-Apple/CFDate.m index 4f39fc68eb0..e71b1a08fac 100644 --- a/clang/test/Analysis-Apple/CFDate.m +++ b/clang/test/Analysis-Apple/CFDate.m @@ -2,6 +2,8 @@ #include <CoreFoundation/CFDate.h> #include <Foundation/NSDate.h> +#include <Foundation/NSCalendarDate.h> +#include <Foundation/NSString.h> CFAbsoluteTime f1() { CFAbsoluteTime t = CFAbsoluteTimeGetCurrent(); @@ -102,3 +104,12 @@ NSDate* f8(int x) { return date; // expected-warning{{leak}} } +NSDate* f9(int x) { + + NSDate* date = [NSDate dateWithString:@"2001-03-24 10:45:32 +0600"]; + + if (x) [date retain]; + + return date; // expected-warning{{leak}} +} + |
