summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPuyan Lotfi <puyan@puyan.org>2020-01-21 22:45:23 -0500
committerHans Wennborg <hans@chromium.org>2020-01-23 23:38:30 +0100
commit2dd6b91f35edb967f329f0437b53ea14395aa770 (patch)
tree36cdec1df54b573037c612447b1f1f9d2cc4c2a2
parent26fd69afd9f3c6bb48b8a4e60578ea8ae919593f (diff)
downloadbcm5719-llvm-2dd6b91f35edb967f329f0437b53ea14395aa770.tar.gz
bcm5719-llvm-2dd6b91f35edb967f329f0437b53ea14395aa770.zip
[clang][IFS][test] Temporary work around for in-process cc1 ASAN issues.
When using in-process cc1, the Clang Interface Stubs pipeline setup exposes an ASAN bug. I am still investigating this issue but want to green the bots for now. I don't think this is a huge issue since the Clang Interface Stubs Driver setup code is the only code path that sets up such a pipeline (ie N cc1's for N c files followed by another N cc1's for to generate stub files for the same N c files). This issue is being discussed in https://reviews.llvm.org/D69825. If a resolution is not found soon, a bugzilla filling will be in order. (cherry picked from commit c38e42527b21acee8d01a016d5bfa2fb83202e29)
-rw-r--r--clang/test/InterfaceStubs/driver-test.c11
-rw-r--r--clang/test/InterfaceStubs/driver-test2.c9
2 files changed, 19 insertions, 1 deletions
diff --git a/clang/test/InterfaceStubs/driver-test.c b/clang/test/InterfaceStubs/driver-test.c
index 9ca5577a5c2..894d896bb21 100644
--- a/clang/test/InterfaceStubs/driver-test.c
+++ b/clang/test/InterfaceStubs/driver-test.c
@@ -1,8 +1,17 @@
// REQUIRES: x86-registered-target
// REQUIRES: shell
+// NOTE: -fno-integrated-cc1 has been added to work around an ASAN failure
+// caused by in-process cc1 invocation. Clang InterfaceStubs is not the
+// culprit, but Clang Interface Stubs' Driver pipeline setup uncovers an
+// existing ASAN issue when invoking multiple normal cc1 jobs along with
+// multiple Clang Interface Stubs cc1 jobs together.
+// There is currently a discussion of this going on at:
+// https://reviews.llvm.org/D69825
// RUN: mkdir -p %t; cd %t
-// RUN: %clang -target x86_64-unknown-linux-gnu -x c -S -emit-interface-stubs %s %S/object.c %S/weak.cpp && \
+// RUN: %clang -target x86_64-unknown-linux-gnu -x c -S \
+// RUN: -fno-integrated-cc1 \
+// RUN: -emit-interface-stubs %s %S/object.c %S/weak.cpp && \
// RUN: llvm-nm %t/a.out.ifso 2>&1 | FileCheck --check-prefix=CHECK-IFS %s
// CHECK-IFS-DAG: data
diff --git a/clang/test/InterfaceStubs/driver-test2.c b/clang/test/InterfaceStubs/driver-test2.c
index c3a3b31b212..905b2792226 100644
--- a/clang/test/InterfaceStubs/driver-test2.c
+++ b/clang/test/InterfaceStubs/driver-test2.c
@@ -1,10 +1,19 @@
// REQUIRES: x86-registered-target
// REQUIRES: shell
+// NOTE: -fno-integrated-cc1 has been added to work around an ASAN failure
+// caused by in-process cc1 invocation. Clang InterfaceStubs is not the
+// culprit, but Clang Interface Stubs' Driver pipeline setup uncovers an
+// existing ASAN issue when invoking multiple normal cc1 jobs along with
+// multiple Clang Interface Stubs cc1 jobs together.
+// There is currently a discussion of this going on at:
+// https://reviews.llvm.org/D69825
// RUN: mkdir -p %t; cd %t
// RUN: %clang -target x86_64-unknown-linux-gnu -c -emit-interface-stubs \
+// RUN: -fno-integrated-cc1 \
// RUN: %s %S/object.c %S/weak.cpp
// RUN: %clang -emit-interface-stubs -emit-merged-ifs \
+// RUN: -fno-integrated-cc1 \
// RUN: %t/driver-test2.o %t/object.o %t/weak.o -S -o - 2>&1 | FileCheck %s
// CHECK-DAG: data
OpenPOWER on IntegriCloud