diff options
author | Fariborz Jahanian <fjahanian@apple.com> | 2015-03-05 23:06:09 +0000 |
---|---|---|
committer | Fariborz Jahanian <fjahanian@apple.com> | 2015-03-05 23:06:09 +0000 |
commit | 28d94b1df214a04f479a65000eb37e56ef5c8c39 (patch) | |
tree | 33ce3b58d87245c21b9cddf1e822da7b04276080 | |
parent | 282b3d3ff5215d406cf9cf5fe129ea875951f011 (diff) | |
download | bcm5719-llvm-28d94b1df214a04f479a65000eb37e56ef5c8c39.tar.gz bcm5719-llvm-28d94b1df214a04f479a65000eb37e56ef5c8c39.zip |
[PATCH] Patch to fix the AST for vector splat from any
arithmetic type to a vector so that the arithmatic type
matches the vector element type. Without which it crashes
in Code Gen. rdar://20000762
llvm-svn: 231419
-rw-r--r-- | clang/lib/Sema/SemaExprCXX.cpp | 14 | ||||
-rw-r--r-- | clang/test/CodeGenCXX/vector-splat-conversion.cpp | 19 |
2 files changed, 31 insertions, 2 deletions
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index 6ad0b24275a..29e5150073d 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -3000,8 +3000,18 @@ Sema::PerformImplicitConversion(Expr *From, QualType ToType, break; case ICK_Vector_Splat: - From = ImpCastExprToType(From, ToType, CK_VectorSplat, - VK_RValue, /*BasePath=*/nullptr, CCK).get(); + // Vector splat from any arithmetic type to a vector. + // Cast to the element type. + { + QualType elType = ToType->getAs<ExtVectorType>()->getElementType(); + if (elType != From->getType()) { + ExprResult E = From; + From = ImpCastExprToType(From, elType, + PrepareScalarCast(E, elType)).get(); + } + From = ImpCastExprToType(From, ToType, CK_VectorSplat, + VK_RValue, /*BasePath=*/nullptr, CCK).get(); + } break; case ICK_Complex_Real: diff --git a/clang/test/CodeGenCXX/vector-splat-conversion.cpp b/clang/test/CodeGenCXX/vector-splat-conversion.cpp new file mode 100644 index 00000000000..410df3dd0ce --- /dev/null +++ b/clang/test/CodeGenCXX/vector-splat-conversion.cpp @@ -0,0 +1,19 @@ +// RUN: %clang_cc1 %s -triple arm64-apple-ios8.1.0 -std=c++11 -emit-llvm -o - | FileCheck %s +// rdar://20000762 + +typedef __attribute__((__ext_vector_type__(8))) float vector_float8; + +typedef vector_float8 float8; + +void MandelbrotPolyCalcSIMD8() +{ + constexpr float8 v4 = 4.0; // value to compare against abs(z)^2, to see if bounded + float8 vABS; + auto vLT = vABS < v4; +} + +// CHECK: store <8 x float> +// CHECK: [[ZERO:%.*]] = load <8 x float>, <8 x float>* [[VARBS:%.*]] +// CHECK: [[CMP:%.*]] = fcmp olt <8 x float> [[ZERO]] +// CHECK: [[SEXT:%.*]] = sext <8 x i1> [[CMP]] to <8 x i32> +// CHECK: store <8 x i32> [[SEXT]], <8 x i32>* [[VLT:%.*]] |