diff options
| author | Rui Ueyama <ruiu@google.com> | 2015-11-30 21:00:53 +0000 |
|---|---|---|
| committer | Rui Ueyama <ruiu@google.com> | 2015-11-30 21:00:53 +0000 |
| commit | 28a661ec8032c9380a4ff5ed890ce881ba1ccc40 (patch) | |
| tree | 5aeffad8a4c4fc21678cdaed15696e01e3603f90 | |
| parent | cdad10f333cf1bf81868b07f4f37d1d45418b103 (diff) | |
| download | bcm5719-llvm-28a661ec8032c9380a4ff5ed890ce881ba1ccc40.tar.gz bcm5719-llvm-28a661ec8032c9380a4ff5ed890ce881ba1ccc40.zip | |
ELF: Make comments consistent.
In other places, we don't have the comment. Absence of check{Int,UInt}
is the sign that no overflow check is needed.
llvm-svn: 254326
| -rw-r--r-- | lld/ELF/Target.cpp | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/lld/ELF/Target.cpp b/lld/ELF/Target.cpp index 3a649029eeb..002b59116c3 100644 --- a/lld/ELF/Target.cpp +++ b/lld/ELF/Target.cpp @@ -948,11 +948,9 @@ void AArch64TargetInfo::relocateOne(uint8_t *Loc, uint8_t *BufEnd, write32le(Loc, SA); break; case R_AARCH64_ABS64: - // No overflow check needed. write64le(Loc, SA); break; case R_AARCH64_ADD_ABS_LO12_NC: - // No overflow check needed. // This relocation stores 12 bits and there's no instruction // to do it. Instead, we do a 32 bits store of the value // of r_addend bitwise-or'ed Loc. This assumes that the addend @@ -980,20 +978,16 @@ void AArch64TargetInfo::relocateOne(uint8_t *Loc, uint8_t *BufEnd, break; } case R_AARCH64_LDST32_ABS_LO12_NC: - // No overflow check needed. or32le(Loc, (SA & 0xFFC) << 8); break; case R_AARCH64_LD64_GOT_LO12_NC: checkAlignment<8>(SA, Type); - // No overflow check needed. or32le(Loc, (SA & 0xFF8) << 7); break; case R_AARCH64_LDST64_ABS_LO12_NC: - // No overflow check needed. or32le(Loc, (SA & 0xFF8) << 7); break; case R_AARCH64_LDST8_ABS_LO12_NC: - // No overflow check needed. or32le(Loc, (SA & 0xFFF) << 10); break; case R_AARCH64_PREL16: @@ -1005,7 +999,6 @@ void AArch64TargetInfo::relocateOne(uint8_t *Loc, uint8_t *BufEnd, write32le(Loc, SA - P); break; case R_AARCH64_PREL64: - // No overflow check needed. write64le(Loc, SA - P); break; default: |
