diff options
| author | Nico Weber <nicolasweber@gmx.de> | 2019-04-23 16:37:42 +0000 |
|---|---|---|
| committer | Nico Weber <nicolasweber@gmx.de> | 2019-04-23 16:37:42 +0000 |
| commit | 27df4092036954fc50e9abc3489dfa428147eeb7 (patch) | |
| tree | 4b26508ec9243cff1671c228358213d9aeeb0f1d | |
| parent | 7c0bd5a27c5b2a09a8ee7219546c7232605a3bda (diff) | |
| download | bcm5719-llvm-27df4092036954fc50e9abc3489dfa428147eeb7.tar.gz bcm5719-llvm-27df4092036954fc50e9abc3489dfa428147eeb7.zip | |
MS ABI: Support mangling op<=> now that MSVC 2019 has a mangling
llvm-svn: 359009
| -rw-r--r-- | clang/lib/AST/MicrosoftMangle.cpp | 11 | ||||
| -rw-r--r-- | clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp | 8 |
2 files changed, 8 insertions, 11 deletions
diff --git a/clang/lib/AST/MicrosoftMangle.cpp b/clang/lib/AST/MicrosoftMangle.cpp index 0d4080cce40..db181210300 100644 --- a/clang/lib/AST/MicrosoftMangle.cpp +++ b/clang/lib/AST/MicrosoftMangle.cpp @@ -1242,15 +1242,8 @@ void MicrosoftCXXNameMangler::mangleOperatorName(OverloadedOperatorKind OO, case OO_Array_Delete: Out << "?_V"; break; // <operator-name> ::= ?__L # co_await case OO_Coawait: Out << "?__L"; break; - - case OO_Spaceship: { - // FIXME: Once MS picks a mangling, use it. - DiagnosticsEngine &Diags = Context.getDiags(); - unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error, - "cannot mangle this three-way comparison operator yet"); - Diags.Report(Loc, DiagID); - break; - } + // <operator-name> ::= ?__M # <=> + case OO_Spaceship: Out << "?__M"; break; case OO_Conditional: { DiagnosticsEngine &Diags = Context.getDiags(); diff --git a/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp b/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp index fd72d4a39cb..83a899f53f8 100644 --- a/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp +++ b/clang/test/CodeGenCXX/cxx2a-three-way-comparison.cpp @@ -1,24 +1,28 @@ // RUN: %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %itanium_abi_triple | FileCheck %s --check-prefix=ITANIUM -// RUN: not %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %ms_abi_triple 2>&1 | FileCheck %s --check-prefix=MSABI +// RUN: %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %ms_abi_triple 2>&1 | FileCheck %s --check-prefix=MSABI // RUN: not %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %itanium_abi_triple -DBUILTIN 2>&1 | FileCheck %s --check-prefix=BUILTIN -// MSABI: cannot mangle this three-way comparison operator yet struct A { void operator<=>(int); }; // ITANIUM: define {{.*}}@_ZN1AssEi( +// MSABI: define {{.*}}@"??__MA@@QEAAXH@Z"( void A::operator<=>(int) {} // ITANIUM: define {{.*}}@_Zssi1A( +// MSABI: define {{.*}}@"??__M@YAXHUA@@@Z"( void operator<=>(int, A) {} int operator<=>(A, A); // ITANIUM: define {{.*}}_Z1f1A( +// MSABI: define {{.*}}@"?f@@YAHUA@@@Z"( int f(A a) { // ITANIUM: %[[RET:.*]] = call {{.*}}_Zss1AS_( // ITANIUM: ret i32 %[[RET]] + // MSABI: %[[RET:.*]] = call {{.*}}"??__M@YAHUA@@0@Z"( + // MSABI: ret i32 %[[RET]] return a <=> a; } |
