diff options
| author | Tilmann Scheller <t.scheller@samsung.com> | 2014-07-23 13:03:47 +0000 |
|---|---|---|
| committer | Tilmann Scheller <t.scheller@samsung.com> | 2014-07-23 13:03:47 +0000 |
| commit | 2727279117eac8671597fe457ac7ef3c5d82abe6 (patch) | |
| tree | 369c8107b58c562c8ed3983ad42788028002c938 | |
| parent | a4d18fc60686ff0d9a138dce6b5ff6f650aa2cb0 (diff) | |
| download | bcm5719-llvm-2727279117eac8671597fe457ac7ef3c5d82abe6.tar.gz bcm5719-llvm-2727279117eac8671597fe457ac7ef3c5d82abe6.zip | |
[ARM] Make the assembler reject unpredictable pre/post-indexed ARM STRB instructions.
The ARM ARM prohibits STRB instructions with writeback into the source register. With this commit this constraint is now enforced and we stop assembling STRB instructions with unpredictable behavior.
llvm-svn: 213750
| -rw-r--r-- | llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 6 | ||||
| -rw-r--r-- | llvm/test/MC/ARM/diagnostics.s | 16 |
2 files changed, 21 insertions, 1 deletions
diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index 5e074c4e429..ccef6c3b6cb 100644 --- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -5731,7 +5731,11 @@ bool ARMAsmParser::validateInstruction(MCInst &Inst, case ARM::STR_PRE_IMM: case ARM::STR_PRE_REG: case ARM::STR_POST_IMM: - case ARM::STR_POST_REG: { + case ARM::STR_POST_REG: + case ARM::STRB_PRE_IMM: + case ARM::STRB_PRE_REG: + case ARM::STRB_POST_IMM: + case ARM::STRB_POST_REG: { // Rt must be different from Rn. const unsigned Rt = MRI->getEncodingValue(Inst.getOperand(1).getReg()); const unsigned Rn = MRI->getEncodingValue(Inst.getOperand(2).getReg()); diff --git a/llvm/test/MC/ARM/diagnostics.s b/llvm/test/MC/ARM/diagnostics.s index e26566df8ee..25eb6f227a6 100644 --- a/llvm/test/MC/ARM/diagnostics.s +++ b/llvm/test/MC/ARM/diagnostics.s @@ -496,6 +496,10 @@ foo2: str r0, [r0, r1]! str r0, [r0], #4 str r0, [r0], r1 + strb r0, [r0, #1]! + strb r0, [r0, r1]! + strb r0, [r0], #1 + strb r0, [r0], r1 @ CHECK-ERRORS: error: source register and base register can't be identical @ CHECK-ERRORS: str r0, [r0, #4]! @ CHECK-ERRORS: ^ @@ -508,3 +512,15 @@ foo2: @ CHECK-ERRORS: error: source register and base register can't be identical @ CHECK-ERRORS: str r0, [r0], r1 @ CHECK-ERRORS: ^ +@ CHECK-ERRORS: error: source register and base register can't be identical +@ CHECK-ERRORS: strb r0, [r0, #1]! +@ CHECK-ERRORS: ^ +@ CHECK-ERRORS: error: source register and base register can't be identical +@ CHECK-ERRORS: strb r0, [r0, r1]! +@ CHECK-ERRORS: ^ +@ CHECK-ERRORS: error: source register and base register can't be identical +@ CHECK-ERRORS: strb r0, [r0], #1 +@ CHECK-ERRORS: ^ +@ CHECK-ERRORS: error: source register and base register can't be identical +@ CHECK-ERRORS: strb r0, [r0], r1 +@ CHECK-ERRORS: ^ |
