summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kornienko <alexfh@google.com>2015-11-06 00:19:21 +0000
committerAlexander Kornienko <alexfh@google.com>2015-11-06 00:19:21 +0000
commit272397b42e7f5823f72acabef2528f6630fd1c4a (patch)
treec2e065fcac0214c610923c6bfbfc76638a64086d
parent34ca831d9fe6d4ac1c73570fddd072ab6c3f7ea4 (diff)
downloadbcm5719-llvm-272397b42e7f5823f72acabef2528f6630fd1c4a.tar.gz
bcm5719-llvm-272397b42e7f5823f72acabef2528f6630fd1c4a.zip
[clang-tidy] readability-named-parameter: don't complain about implicit parameters
Fixes http://llvm.org/PR24464. llvm-svn: 252248
-rw-r--r--clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp2
-rw-r--r--clang-tools-extra/test/clang-tidy/readability-named-parameter.cpp4
2 files changed, 6 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp b/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp
index 2409a8b08b5..ffdc813beeb 100644
--- a/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp
@@ -45,6 +45,8 @@ void NamedParameterCheck::check(const MatchFinder::MatchResult &Result) {
// arguments in the same position.
for (unsigned I = 0, E = Function->getNumParams(); I != E; ++I) {
const ParmVarDecl *Parm = Function->getParamDecl(I);
+ if (Parm->isImplicit())
+ continue;
// Look for unnamed parameters.
if (!Parm->getName().empty())
continue;
diff --git a/clang-tools-extra/test/clang-tidy/readability-named-parameter.cpp b/clang-tools-extra/test/clang-tidy/readability-named-parameter.cpp
index f2d31e26999..af2c1954bc5 100644
--- a/clang-tools-extra/test/clang-tidy/readability-named-parameter.cpp
+++ b/clang-tools-extra/test/clang-tidy/readability-named-parameter.cpp
@@ -127,3 +127,7 @@ typedef decltype(nullptr) nullptr_t;
}
void f(std::nullptr_t) {}
+
+typedef void (F)(int);
+F f;
+void f(int x) {}
OpenPOWER on IntegriCloud