diff options
| author | Raphael Isemann <teemperor@gmail.com> | 2018-09-11 13:59:47 +0000 |
|---|---|---|
| committer | Raphael Isemann <teemperor@gmail.com> | 2018-09-11 13:59:47 +0000 |
| commit | 262dd8c9dfae9d72bbb310e7d4c1bd6ebbe8780e (patch) | |
| tree | 2d1bc1c1352c926e144f7b82234e1112084f3af6 | |
| parent | 30a782176018067591e553bcf3ec8183581b0826 (diff) | |
| download | bcm5719-llvm-262dd8c9dfae9d72bbb310e7d4c1bd6ebbe8780e.tar.gz bcm5719-llvm-262dd8c9dfae9d72bbb310e7d4c1bd6ebbe8780e.zip | |
Print the correct error when our DynamicCheckerFunctions fail to install
Summary:
The check is inverted here: If we have error messages, we should print those instead
of our default error message. But currently we print the default message when we
actually have a sensible error to print.
Fixes https://bugs.llvm.org/show_bug.cgi?id=38383
Thanks Nat for the patch!
Reviewers: #lldb, JDevlieghere
Reviewed By: JDevlieghere
Subscribers: JDevlieghere, lldb-commits
Differential Revision: https://reviews.llvm.org/D51602
llvm-svn: 341940
| -rw-r--r-- | lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp index bf41126dbf6..b905b9a1d57 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp @@ -1162,9 +1162,9 @@ lldb_private::Status ClangExpressionParser::PrepareForExecution( if (!dynamic_checkers->Install(install_diagnostics, exe_ctx)) { if (install_diagnostics.Diagnostics().size()) - err.SetErrorString("couldn't install checkers, unknown error"); - else err.SetErrorString(install_diagnostics.GetString().c_str()); + else + err.SetErrorString("couldn't install checkers, unknown error"); return err; } |

