diff options
| author | Sanjay Patel <spatel@rotateright.com> | 2016-05-17 20:20:40 +0000 |
|---|---|---|
| committer | Sanjay Patel <spatel@rotateright.com> | 2016-05-17 20:20:40 +0000 |
| commit | 22b01febd4a92a0f38febf5aec6cf4e0de04fd8d (patch) | |
| tree | 0788e593b94fb0ae9bd8516e3d39c678a0ae095e | |
| parent | 12de0b91ac1f585ed7d11a25fc7cb841a1826aa3 (diff) | |
| download | bcm5719-llvm-22b01febd4a92a0f38febf5aec6cf4e0de04fd8d.tar.gz bcm5719-llvm-22b01febd4a92a0f38febf5aec6cf4e0de04fd8d.zip | |
[InstCombine] add another test for wrong icmp constant (PR27792)
It doesn't matter if the comparison is unsigned; the inc/dec is always signed.
llvm-svn: 269831
| -rw-r--r-- | llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp | 2 | ||||
| -rw-r--r-- | llvm/test/Transforms/InstCombine/icmp.ll | 11 |
2 files changed, 11 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp index f51cf7321f2..6a38baefe5a 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp @@ -3150,7 +3150,7 @@ static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { // Increment or decrement the constant and set the new comparison predicate: // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT - Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, IsSigned); + Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true); CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT; NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred; return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne)); diff --git a/llvm/test/Transforms/InstCombine/icmp.ll b/llvm/test/Transforms/InstCombine/icmp.ll index 099d15944ab..4575e1017ff 100644 --- a/llvm/test/Transforms/InstCombine/icmp.ll +++ b/llvm/test/Transforms/InstCombine/icmp.ll @@ -2098,7 +2098,7 @@ return: ; preds = %if.end, %entry, %if ret void } -; When canonicalizing to 'sgt', make sure the constant is correct. +; When canonicalizing to 'gt/lt', make sure the constant is correct. define i1 @PR27792(i128 %a) { ; CHECK-LABEL: @PR27792( @@ -2109,3 +2109,12 @@ define i1 @PR27792(i128 %a) { ret i1 %cmp } +define i1 @PR27792_2(i128 %a) { +; CHECK-LABEL: @PR27792_2( +; CHECK-NEXT: [[B:%.*]] = icmp ne i128 %a, 0 +; CHECK-NEXT: ret i1 [[B]] +; + %b = icmp uge i128 %a, 1 + ret i1 %b +} + |
