summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorReid Kleckner <rnk@google.com>2019-12-05 16:01:58 -0800
committerReid Kleckner <rnk@google.com>2019-12-05 16:24:24 -0800
commit1f822f212cde1ad9099cf45af0652a83380de772 (patch)
treeb62f9716dbf87f5942a8af8cdd7f0da59c04dde0
parent532196d811ad4db1e522012c9d20e4a95aae2eb3 (diff)
downloadbcm5719-llvm-1f822f212cde1ad9099cf45af0652a83380de772.tar.gz
bcm5719-llvm-1f822f212cde1ad9099cf45af0652a83380de772.zip
Handle two corner cases in creduce-clang-crash.py
Summary: First, call os.path.normpath on the filename argument. I passed in ./foo-asdf.cpp, and this meant that the script failed to find the filename, and bad things happened. Second, call os.path.abspath on binaries. CReduce runs the interestingness test in a temp dir, so relative paths will not work. Reviewers: akhuang Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D71098
-rwxr-xr-xclang/utils/creduce-clang-crash.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/clang/utils/creduce-clang-crash.py b/clang/utils/creduce-clang-crash.py
index e886bf72e5a..b69d6efc248 100755
--- a/clang/utils/creduce-clang-crash.py
+++ b/clang/utils/creduce-clang-crash.py
@@ -30,6 +30,7 @@ def verbose_print(*args, **kwargs):
print(*args, **kwargs)
def check_file(fname):
+ fname = os.path.normpath(fname)
if not os.path.isfile(fname):
sys.exit("ERROR: %s does not exist" % (fname))
return fname
@@ -40,6 +41,8 @@ def check_cmd(cmd_name, cmd_dir, cmd_path=None):
or absolute path to cmd_dir/cmd_name.
"""
if cmd_path:
+ # Make the path absolute so the creduce test can be run from any directory.
+ cmd_path = os.path.abspath(cmd_path)
cmd = find_executable(cmd_path)
if cmd:
return cmd
OpenPOWER on IntegriCloud