diff options
author | JF Bastien <jfb@google.com> | 2016-04-12 21:13:01 +0000 |
---|---|---|
committer | JF Bastien <jfb@google.com> | 2016-04-12 21:13:01 +0000 |
commit | 1bb32ac4806f782380099bdb1caa382253f18b1a (patch) | |
tree | 489d4d56764121567eca63a9b41adc3201f5da1b | |
parent | 1bc232d342cb9491a0683584df745c3c2fa393bd (diff) | |
download | bcm5719-llvm-1bb32ac4806f782380099bdb1caa382253f18b1a.tar.gz bcm5719-llvm-1bb32ac4806f782380099bdb1caa382253f18b1a.zip |
NFC: MergeFunctions update more comments
They are wordy. Some words were wrong.
llvm-svn: 266124
-rw-r--r-- | llvm/lib/Transforms/IPO/MergeFunctions.cpp | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/llvm/lib/Transforms/IPO/MergeFunctions.cpp b/llvm/lib/Transforms/IPO/MergeFunctions.cpp index 63e610cc258..b08e7f7a287 100644 --- a/llvm/lib/Transforms/IPO/MergeFunctions.cpp +++ b/llvm/lib/Transforms/IPO/MergeFunctions.cpp @@ -320,8 +320,8 @@ private: int cmpValues(const Value *L, const Value *R); /// Compare two Instructions for equivalence, similar to - /// Instruction::isSameOperationAs but with modifications to the type - /// comparison. + /// Instruction::isSameOperationAs. + /// /// Stages are listed in "most significant stage first" order: /// On each stage below, we do comparison between some left and right /// operation parts. If parts are non-equal, we assign parts comparison @@ -339,8 +339,9 @@ private: /// For example, for Load it would be: /// 6.1.Load: volatile (as boolean flag) /// 6.2.Load: alignment (as integer numbers) - /// 6.3.Load: synch-scope (as integer numbers) - /// 6.4.Load: range metadata (as integer numbers) + /// 6.3.Load: ordering (as underlying enum class value) + /// 6.4.Load: synch-scope (as integer numbers) + /// 6.5.Load: range metadata (as integer ranges) /// On this stage its better to see the code, since its not more than 10-15 /// strings for particular instruction, and could change sometimes. int cmpOperations(const Instruction *L, const Instruction *R) const; @@ -905,9 +906,9 @@ int FunctionComparator::cmpTypes(Type *TyL, Type *TyR) const { int FunctionComparator::cmpOperations(const Instruction *L, const Instruction *R) const { // Differences from Instruction::isSameOperationAs: - // * replace type comparison with calls to isEquivalentType. - // * we test for I->hasSameSubclassOptionalData (nuw/nsw/tail) at the top - // * because of the above, we don't test for the tail bit on calls later on + // * replace type comparison with calls to cmpTypes. + // * we test for I->getRawSubclassOptionalData (nuw/nsw/tail) at the top. + // * because of the above, we don't test for the tail bit on calls later on. if (int Res = cmpNumbers(L->getOpcode(), R->getOpcode())) return Res; |