summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEnrico Granata <egranata@apple.com>2015-01-08 00:29:12 +0000
committerEnrico Granata <egranata@apple.com>2015-01-08 00:29:12 +0000
commit1a4d0785833bd2bc964844eb25fe0fccdd559a8e (patch)
tree3cb48fc2e069bca46c06ab824d7fcf9cae4357d1
parent66d51fc41a61a7433915cd958f9796292391b490 (diff)
downloadbcm5719-llvm-1a4d0785833bd2bc964844eb25fe0fccdd559a8e.tar.gz
bcm5719-llvm-1a4d0785833bd2bc964844eb25fe0fccdd559a8e.zip
Fix a problem where a ValueObject could fail to update itself, but since it was previously valid, we'd have an old checksum to compare aginst no new checksum (because failure to update), and assert() and die. Fix the problem by only caring about this assertion logic if updates succeed
llvm-svn: 225418
-rw-r--r--lldb/source/Core/ValueObject.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp
index 1bf33787294..25219e57478 100644
--- a/lldb/source/Core/ValueObject.cpp
+++ b/lldb/source/Core/ValueObject.cpp
@@ -250,7 +250,7 @@ ValueObject::UpdateValueIfNeeded (bool update_format)
m_value_checksum.clear();
}
- assert (old_checksum.empty() == !need_compare_checksums);
+ assert (success && (old_checksum.empty() == !need_compare_checksums));
if (first_update)
SetValueDidChange (false);
OpenPOWER on IntegriCloud