summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Dunbar <daniel@zuster.org>2010-01-26 03:56:40 +0000
committerDaniel Dunbar <daniel@zuster.org>2010-01-26 03:56:40 +0000
commit19afd61201b121ee878a2eac6e03a8887cf68b1b (patch)
tree89d057b85419b92aa0011457ed93106b5938f618
parenta8d7385d991edd445b7a638a2200b92c56a8495f (diff)
downloadbcm5719-llvm-19afd61201b121ee878a2eac6e03a8887cf68b1b.tar.gz
bcm5719-llvm-19afd61201b121ee878a2eac6e03a8887cf68b1b.zip
Simplify.
llvm-svn: 94503
-rw-r--r--clang/lib/Driver/ToolChains.h10
-rw-r--r--clang/lib/Driver/Tools.cpp19
2 files changed, 5 insertions, 24 deletions
diff --git a/clang/lib/Driver/ToolChains.h b/clang/lib/Driver/ToolChains.h
index 89478d5f157..82fdf825d07 100644
--- a/clang/lib/Driver/ToolChains.h
+++ b/clang/lib/Driver/ToolChains.h
@@ -67,8 +67,6 @@ class VISIBILITY_HIDDEN Darwin : public ToolChain {
/// The default iphoneos-version-min of this tool chain.
std::string IPhoneOSVersionMin;
- const char *getMacosxVersionMin() const;
-
public:
Darwin(const HostInfo &Host, const llvm::Triple& Triple,
const unsigned (&DarwinVersion)[3], bool IsIPhoneOS);
@@ -112,14 +110,6 @@ public:
return isMacosxVersionLT(A, B);
}
- const char *getMacosxVersionStr() const {
- return MacosxVersionMin.c_str();
- }
-
- const char *getIPhoneOSVersionStr() const {
- return IPhoneOSVersionMin.c_str();
- }
-
/// AddLinkSearchPathArgs - Add the linker search paths to \arg CmdArgs.
///
/// \param Args - The input argument list.
diff --git a/clang/lib/Driver/Tools.cpp b/clang/lib/Driver/Tools.cpp
index 61b4ee675ef..edacafa49b5 100644
--- a/clang/lib/Driver/Tools.cpp
+++ b/clang/lib/Driver/Tools.cpp
@@ -1948,20 +1948,11 @@ void darwin::Link::AddLinkArgs(const ArgList &Args,
Args.AddAllArgs(CmdArgs, options::OPT_image__base);
Args.AddAllArgs(CmdArgs, options::OPT_init);
- if (!Args.hasArg(options::OPT_mmacosx_version_min_EQ) &&
- !Args.hasArg(options::OPT_miphoneos_version_min_EQ)) {
- // Add default version min.
- if (!getDarwinToolChain().isIPhoneOS()) {
- CmdArgs.push_back("-macosx_version_min");
- CmdArgs.push_back(getDarwinToolChain().getMacosxVersionStr());
- } else {
- CmdArgs.push_back("-iphoneos_version_min");
- CmdArgs.push_back(getDarwinToolChain().getIPhoneOSVersionStr());
- }
- }
-
- // Adding all arguments doesn't make sense here but this is what
- // gcc does.
+ // Adding all arguments doesn't make sense here but this is what gcc does. One
+ // of this should always be present thanks to argument translation.
+ assert((Args.hasArg(options::OPT_mmacosx_version_min_EQ) ||
+ Args.hasArg(options::OPT_miphoneos_version_min_EQ)) &&
+ "Missing version argument (lost in translation)?");
Args.AddAllArgsTranslated(CmdArgs, options::OPT_mmacosx_version_min_EQ,
"-macosx_version_min");
Args.AddAllArgsTranslated(CmdArgs, options::OPT_miphoneos_version_min_EQ,
OpenPOWER on IntegriCloud