summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Jasper <djasper@google.com>2015-01-14 10:36:31 +0000
committerDaniel Jasper <djasper@google.com>2015-01-14 10:36:31 +0000
commit190fbda6ded9cfdf67b0903e82a0cd0853da3a73 (patch)
tree9da7a0f8cbca8c62192f5a0ab81d865d3b79a840
parenta18dcf7efdf0a0574bbdf67cfa66f51aa3373568 (diff)
downloadbcm5719-llvm-190fbda6ded9cfdf67b0903e82a0cd0853da3a73.tar.gz
bcm5719-llvm-190fbda6ded9cfdf67b0903e82a0cd0853da3a73.zip
clang-format: [Java] Prefer not to break in parameter annotations.
Before: boolean someFunction(@Param(aaaaaaaaaaaaaaaa) String aaaaa, String bbbbbbbbbbbbbbb) {} After: boolean someFunction( @Param(aaaaaaaaaaaaaaaa) String aaaaa, String bbbbbbbbbbbbbbb) {} llvm-svn: 225971
-rw-r--r--clang/lib/Format/TokenAnnotator.cpp2
-rw-r--r--clang/unittests/Format/FormatTestJava.cpp6
2 files changed, 8 insertions, 0 deletions
diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp
index 34d8835c763..d0d888fa4d4 100644
--- a/clang/lib/Format/TokenAnnotator.cpp
+++ b/clang/lib/Format/TokenAnnotator.cpp
@@ -1587,6 +1587,8 @@ unsigned TokenAnnotator::splitPenalty(const AnnotatedLine &Line,
return Left.ParameterCount > 1 ? Style.PenaltyBreakBeforeFirstCallParameter
: 19;
}
+ if (Left.is(TT_JavaAnnotation))
+ return 50;
if (Right.is(tok::lessless)) {
if (Left.is(tok::string_literal)) {
diff --git a/clang/unittests/Format/FormatTestJava.cpp b/clang/unittests/Format/FormatTestJava.cpp
index 9b3b9933572..af4199b46fc 100644
--- a/clang/unittests/Format/FormatTestJava.cpp
+++ b/clang/unittests/Format/FormatTestJava.cpp
@@ -287,6 +287,12 @@ TEST_F(FormatTestJava, Annotations) {
"ReturnType doSomething(\n"
" String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}",
getStyleWithColumns(60));
+ verifyFormat("{\n"
+ " boolean someFunction(\n"
+ " @Param(aaaaaaaaaaaaaaaa) String aaaaa,\n"
+ " String bbbbbbbbbbbbbbb) {}\n"
+ "}",
+ getStyleWithColumns(60));
}
TEST_F(FormatTestJava, Generics) {
OpenPOWER on IntegriCloud