summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephane Sezer <sas@cd80.net>2016-07-13 17:34:26 +0000
committerStephane Sezer <sas@cd80.net>2016-07-13 17:34:26 +0000
commit1852a784161c6a61ff1446e267c5e459f2c2a268 (patch)
tree97a4cc9e264ddb3a57699989680030ed2037d001
parent0e27d67a98f648ffb6c0c0c4b9e82fbb07de3ccb (diff)
downloadbcm5719-llvm-1852a784161c6a61ff1446e267c5e459f2c2a268.tar.gz
bcm5719-llvm-1852a784161c6a61ff1446e267c5e459f2c2a268.zip
Fix a check in the objc trampoline handler
Summary: The function FunctionCaller::WriteFunctionArguments returns false on errors, so they should check for the false return value. Change by Walter Erquinigo <a20012251@gmail.com> Reviewers: jingham, clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D22278 llvm-svn: 275287
-rw-r--r--lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp
index 469d8bdee8a..5fedb80e29a 100644
--- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp
+++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp
@@ -818,7 +818,7 @@ AppleObjCTrampolineHandler::SetupDispatchFunction(Thread &thread, ValueList &dis
// if other threads were calling into here, but actually it isn't because we allocate a new args structure for
// this call by passing args_addr = LLDB_INVALID_ADDRESS...
- if (impl_function_caller->WriteFunctionArguments(exe_ctx, args_addr, dispatch_values, diagnostics))
+ if (!impl_function_caller->WriteFunctionArguments(exe_ctx, args_addr, dispatch_values, diagnostics))
{
if (log)
{
OpenPOWER on IntegriCloud