summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFariborz Jahanian <fjahanian@apple.com>2013-01-22 19:05:17 +0000
committerFariborz Jahanian <fjahanian@apple.com>2013-01-22 19:05:17 +0000
commit177480645a002866a197127d0e244ddd33c115c2 (patch)
tree991eb2dc8387250ee77af2a5cd2503fc360ad5c9
parent583860339b497e2549d7d6dd2f8147aac1aa71f6 (diff)
downloadbcm5719-llvm-177480645a002866a197127d0e244ddd33c115c2.tar.gz
bcm5719-llvm-177480645a002866a197127d0e244ddd33c115c2.zip
Small code change to improve performance
in my last patch, suggested by Argyrios. llvm-svn: 173182
-rw-r--r--clang/include/clang/Sema/Sema.h3
-rw-r--r--clang/lib/Sema/SemaExprObjC.cpp8
2 files changed, 9 insertions, 2 deletions
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index a3402782a9c..20d3db625a4 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -575,6 +575,9 @@ public:
/// \brief id<NSCopying> type.
QualType QIDNSCopying;
+ /// \brief will hold 'respondsToSelector:'
+ Selector RespondsToSelectorSel;
+
/// A flag to remember whether the implicit forms of operator new and delete
/// have been declared.
bool GlobalNewDeleteDeclared;
diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp
index 87da4401916..7f0c832575b 100644
--- a/clang/lib/Sema/SemaExprObjC.cpp
+++ b/clang/lib/Sema/SemaExprObjC.cpp
@@ -2485,8 +2485,12 @@ ExprResult Sema::ActOnInstanceMessage(Scope *S,
MultiExprArg Args) {
if (!Receiver)
return ExprError();
- IdentifierInfo *SelectorId = &Context.Idents.get("respondsToSelector");
- if (Sel == Context.Selectors.getUnarySelector(SelectorId))
+
+ if (RespondsToSelectorSel.isNull()) {
+ IdentifierInfo *SelectorId = &Context.Idents.get("respondsToSelector");
+ RespondsToSelectorSel = Context.Selectors.getUnarySelector(SelectorId);
+ }
+ if (Sel == RespondsToSelectorSel)
RemoveSelectorFromWarningCache(*this, Args[0]);
return BuildInstanceMessage(Receiver, Receiver->getType(),
OpenPOWER on IntegriCloud