summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFangrui Song <maskray@google.com>2019-05-28 10:12:06 +0000
committerFangrui Song <maskray@google.com>2019-05-28 10:12:06 +0000
commit173a68f1fb7958398f8366e6345cb0cda81757dc (patch)
treea900cf488e7e6574a7946337837b7827953e4f3b
parentf57bd6bd23d6224a77b08cb37ee717f804c970d5 (diff)
downloadbcm5719-llvm-173a68f1fb7958398f8366e6345cb0cda81757dc.tar.gz
bcm5719-llvm-173a68f1fb7958398f8366e6345cb0cda81757dc.zip
[ELF] Replace two addSymbol() call sites with Symbol::resolve(). NFC
If we have a handle of the symbol, insert() called by addSymbol() is redundant. Just call resolve(). llvm-svn: 361802
-rw-r--r--lld/ELF/Writer.cpp11
1 files changed, 5 insertions, 6 deletions
diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index 58fc6fab7c9..dd2cae8e861 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -180,9 +180,9 @@ static Defined *addOptionalRegular(StringRef Name, SectionBase *Sec,
if (!S || S->isDefined())
return nullptr;
- return cast<Defined>(Symtab->addSymbol(
- Defined{/*File=*/nullptr, Name, Binding, StOther, STT_NOTYPE, Val,
- /*Size=*/0, Sec}));
+ S->resolve(Defined{/*File=*/nullptr, Name, Binding, StOther, STT_NOTYPE, Val,
+ /*Size=*/0, Sec});
+ return cast<Defined>(S);
}
static Defined *addAbsolute(StringRef Name) {
@@ -239,9 +239,8 @@ void elf::addReservedSymbols() {
if (Config->EMachine == EM_PPC || Config->EMachine == EM_PPC64)
GotOff = 0x8000;
- Symtab->addSymbol(Defined{/*File=*/nullptr, GotSymName, STB_GLOBAL,
- STV_HIDDEN, STT_NOTYPE, GotOff, /*Size=*/0,
- Out::ElfHeader});
+ S->resolve(Defined{/*File=*/nullptr, GotSymName, STB_GLOBAL, STV_HIDDEN,
+ STT_NOTYPE, GotOff, /*Size=*/0, Out::ElfHeader});
ElfSym::GlobalOffsetTable = cast<Defined>(S);
}
OpenPOWER on IntegriCloud