diff options
author | Farhana Aleen <farhana.aleen@gmail.com> | 2018-05-02 16:48:52 +0000 |
---|---|---|
committer | Farhana Aleen <farhana.aleen@gmail.com> | 2018-05-02 16:48:52 +0000 |
commit | 150cb6d91af313b84f1876e8a1f016cfe1e1e6d5 (patch) | |
tree | 65b03a5094e9ec02739a914b2d74899ec7d1841b | |
parent | 8e71ee3c07e9ad64ec36661f1f3aff253e9435d5 (diff) | |
download | bcm5719-llvm-150cb6d91af313b84f1876e8a1f016cfe1e1e6d5.tar.gz bcm5719-llvm-150cb6d91af313b84f1876e8a1f016cfe1e1e6d5.zip |
Revert "[AMDGPU] performAddCombine should run after DAG is legalized."
This reverts commit 6b97d2995566b4dddd6bf0d75579ff44501d4494.
llvm-svn: 331371
-rw-r--r-- | llvm/lib/Target/AMDGPU/SIISelLowering.cpp | 2 | ||||
-rw-r--r-- | llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll | 39 |
2 files changed, 1 insertions, 40 deletions
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp index d98c2a272c9..1ed6dd963fa 100644 --- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp +++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp @@ -6755,7 +6755,7 @@ SDValue SITargetLowering::performAddCombine(SDNode *N, return SDValue(); } - if (VT != MVT::i32 || !DCI.isAfterLegalizeDAG()) + if (VT != MVT::i32) return SDValue(); // add x, zext (setcc) => addcarry x, 0, setcc diff --git a/llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll b/llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll index fbd9fd8bb6e..f94b2fa3aa3 100644 --- a/llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll +++ b/llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll @@ -1,13 +1,10 @@ ; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s -; RUN: llc -march=amdgcn -mcpu=gfx902 -verify-machineinstrs < %s | FileCheck -check-prefix=GFX9 %s ; GCN-LABEL: {{^}}add1: ; GCN: v_cmp_gt_u32_e{{32|64}} [[CC:[^,]+]], v{{[0-9]+}}, v{{[0-9]+}} ; GCN: v_addc_u32_e{{32|64}} v{{[0-9]+}}, {{[^,]+}}, 0, v{{[0-9]+}}, [[CC]] ; GCN-NOT: v_cndmask -; GFX9-LABEL: {{^}}add1: -; GFX9: v_addc_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @add1(i32 addrspace(1)* nocapture %arg) { bb: %x = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -21,33 +18,11 @@ bb: ret void } -; GCN-LABEL: {{^}}add1_i16: -; GCN: v_cmp_gt_u32_e{{32|64}} [[CC:[^,]+]], v{{[0-9]+}}, v{{[0-9]+}} -; GCN: v_addc_u32_e{{32|64}} v{{[0-9]+}}, {{[^,]+}}, 0, v{{[0-9]+}}, [[CC]] -; GCN-NOT: v_cndmask - -; GFX9-LABEL: {{^}}add1_i16: -; GFX9: v_addc_co_u32_e32 v{{[0-9]+}}, vcc -define i16 @add1_i16(i32 addrspace(1)* nocapture %arg, i16 addrspace(1)* nocapture %dst) { -bb: - %x = tail call i32 @llvm.amdgcn.workitem.id.x() - %y = tail call i32 @llvm.amdgcn.workitem.id.y() - %gep = getelementptr inbounds i32, i32 addrspace(1)* %arg, i32 %x - %v = load i32, i32 addrspace(1)* %gep, align 4 - %cmp = icmp ugt i32 %x, %y - %ext = zext i1 %cmp to i32 - %add = add i32 %v, %ext - %trunc = trunc i32 %add to i16 - ret i16 %trunc -} - ; GCN-LABEL: {{^}}sub1: ; GCN: v_cmp_gt_u32_e32 vcc, v{{[0-9]+}}, v{{[0-9]+}} ; GCN: v_subbrev_u32_e32 v{{[0-9]+}}, vcc, 0, v{{[0-9]+}}, vcc ; GCN-NOT: v_cndmask -; GFX9-LABEL: {{^}}sub1: -; GFX9: v_subbrev_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @sub1(i32 addrspace(1)* nocapture %arg) { bb: %x = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -67,8 +42,6 @@ bb: ; GCN-NOT: v_cndmask ; GCN-NOT: v_add -; GFX9-LABEL: {{^}}add_adde: -; GFX9: v_addc_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @add_adde(i32 addrspace(1)* nocapture %arg, i32 %a) { bb: %x = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -89,8 +62,6 @@ bb: ; GCN-NOT: v_cndmask ; GCN-NOT: v_add -; GFX9-LABEL: {{^}}adde_add: -; GFX9: v_addc_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @adde_add(i32 addrspace(1)* nocapture %arg, i32 %a) { bb: %x = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -111,8 +82,6 @@ bb: ; GCN-NOT: v_cndmask ; GCN-NOT: v_sub -; GFX9-LABEL: {{^}}sub_sube: -; GFX9: v_subb_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @sub_sube(i32 addrspace(1)* nocapture %arg, i32 %a) { bb: %x = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -133,8 +102,6 @@ bb: ; GCN-NOT: v_cndmask ; GCN-NOT: v_sub -; GFX9-LABEL: {{^}}sube_sub: -; GFX9: v_subb_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @sube_sub(i32 addrspace(1)* nocapture %arg, i32 %a) { bb: %x = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -154,8 +121,6 @@ bb: ; GCN: v_addc_u32_e{{32|64}} v{{[0-9]+}}, {{[^,]+}}, 0, v{{[0-9]+}}, [[CC]] ; GCN-NOT: v_cndmask -; GFX9-LABEL: {{^}}zext_flclass: -; GFX9: v_addc_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @zext_flclass(i32 addrspace(1)* nocapture %arg, float %x) { bb: %id = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -173,8 +138,6 @@ bb: ; GCN: v_subbrev_u32_e32 v{{[0-9]+}}, vcc, 0, v{{[0-9]+}}, vcc ; GCN-NOT: v_cndmask -; GFX9-LABEL: {{^}}sext_flclass: -; GFX9: v_subbrev_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @sext_flclass(i32 addrspace(1)* nocapture %arg, float %x) { bb: %id = tail call i32 @llvm.amdgcn.workitem.id.x() @@ -192,8 +155,6 @@ bb: ; GCN: v_addc_u32_e{{32|64}} v{{[0-9]+}}, {{[^,]+}}, 0, v{{[0-9]+}}, [[CC]] ; GCN-NOT: v_cndmask -; GFX9-LABEL: {{^}}add_and: -; GFX9: v_addc_co_u32_e32 v{{[0-9]+}}, vcc define amdgpu_kernel void @add_and(i32 addrspace(1)* nocapture %arg) { bb: %x = tail call i32 @llvm.amdgcn.workitem.id.x() |