summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorManman Ren <manman.ren@gmail.com>2013-07-25 21:19:31 +0000
committerManman Ren <manman.ren@gmail.com>2013-07-25 21:19:31 +0000
commit13b63e89837a1f10b03eafb85a491014c4459519 (patch)
tree243e709fb2c71a3da181ceffeb0926e02dd6dc71
parent9260ed6c06c69e62730ab96b455395c497f5af31 (diff)
downloadbcm5719-llvm-13b63e89837a1f10b03eafb85a491014c4459519.tar.gz
bcm5719-llvm-13b63e89837a1f10b03eafb85a491014c4459519.zip
Debug Info: update comments and add a FIXME.
llvm-svn: 187157
-rw-r--r--llvm/lib/IR/DebugInfo.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/llvm/lib/IR/DebugInfo.cpp b/llvm/lib/IR/DebugInfo.cpp
index bbdff5e4831..750231658f1 100644
--- a/llvm/lib/IR/DebugInfo.cpp
+++ b/llvm/lib/IR/DebugInfo.cpp
@@ -406,9 +406,12 @@ bool DIObjCProperty::Verify() const {
return DbgNode->getNumOperands() == 8;
}
-/// We allow an empty string to represent null. But we don't allow
-/// a non-empty string in a MDNode field.
+/// Check if a field at position Elt of a MDNode is a MDNode.
+/// We currently allow an empty string and an integer.
+/// But we don't allow a non-empty string in a MDNode field.
static bool fieldIsMDNode(const MDNode *DbgNode, unsigned Elt) {
+ // FIXME: This function should return true, if the field is null or the field
+ // is indeed a MDNode: return !Fld || isa<MDNode>(Fld).
Value *Fld = getField(DbgNode, Elt);
if (Fld && isa<MDString>(Fld) &&
!cast<MDString>(Fld)->getString().empty())
OpenPOWER on IntegriCloud