summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKaelyn Uhrain <rikka@google.com>2011-08-10 19:47:25 +0000
committerKaelyn Uhrain <rikka@google.com>2011-08-10 19:47:25 +0000
commit0fb0bb179a162ee4e1971e8349fafd9c3daae2ac (patch)
tree1a8ed7a856002f74412ed5617537103d6c1f6812
parent410a11fe824b52b1f038b26803ce635af3e37013 (diff)
downloadbcm5719-llvm-0fb0bb179a162ee4e1971e8349fafd9c3daae2ac.tar.gz
bcm5719-llvm-0fb0bb179a162ee4e1971e8349fafd9c3daae2ac.zip
Add a test case for the divide-by-zero fix in r137234
llvm-svn: 137240
-rw-r--r--clang/lib/Sema/SemaChecking.cpp1
-rw-r--r--clang/test/Sema/array-bounds-ptr-arith.c14
2 files changed, 15 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index d1fa1965693..94e1c4f331e 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -3553,6 +3553,7 @@ void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
// Make sure we're comparing apples to apples when comparing index to size
uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
uint64_t array_typesize = Context.getTypeSize(BaseType);
+ // Handle ptrarith_typesize being zero, such as when casting to void*
if (!ptrarith_typesize) ptrarith_typesize = 1;
if (ptrarith_typesize != array_typesize) {
// There's a cast to a different size type involved
diff --git a/clang/test/Sema/array-bounds-ptr-arith.c b/clang/test/Sema/array-bounds-ptr-arith.c
new file mode 100644
index 00000000000..c0e0d0ea785
--- /dev/null
+++ b/clang/test/Sema/array-bounds-ptr-arith.c
@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -verify -Warray-bounds-pointer-arithmetic %s
+
+// Test case from PR10615
+struct ext2_super_block{
+ unsigned char s_uuid[8]; // expected-note {{declared here}}
+};
+void* ext2_statfs (struct ext2_super_block *es,int a)
+{
+ return (void *)es->s_uuid + sizeof(int); // no-warning
+}
+void* broken (struct ext2_super_block *es,int a)
+{
+ return (void *)es->s_uuid + 80; // expected-warning {{refers past the end of the array}}
+}
OpenPOWER on IntegriCloud